Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert lookback blocks to 128 #13812

Closed
wants to merge 3 commits into from
Closed

Conversation

ferglor
Copy link
Collaborator

@ferglor ferglor commented Jul 10, 2024

Running the load test with 500x1 upkeeps encountered a strange issue after running for ~25 minutes:

key sync timeout, consider increasing key_sync_timeout in seth.toml, or increasing the number of keys

@anirudhwarrier tried adjusting the number of keys and increasing the gas limit, but this only offset when this issue occurred

Additionally, we observed that after a few minutes, the number of transactions per block had doubled beyond what was expected based on previous runs, e.g. the previous runs looked like:

image

Whereas with lookbackBlocks set to 100, we saw this:

image

Going back over the latest develop merges, the culprit was my PR for dequeuing minimum number of logs

The 500x1 test had ran successfully on the feature branch, but not after we changed the lookback blocks from 128 to 100

This PR reverts that one change, and the 500x1 load test now runs without this issue, though I'm not sure yet why it caused this issue

@ferglor ferglor requested a review from a team as a code owner July 10, 2024 17:40
@ferglor ferglor changed the title Reset factory config Revert lookback blocks Jul 10, 2024
@ferglor ferglor requested a review from a team as a code owner July 10, 2024 19:06
@ferglor ferglor changed the title Revert lookback blocks Revert lookback blocks to 128 Jul 10, 2024
@cl-sonarqube-production
Copy link

@ferglor ferglor closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants