[BCI-3573] - Remove dependence on FinalityDepth in EVM TXM code #13755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
…-get-transaction-status-method
|
Farber98
changed the base branch from
develop
to
BCI-3486-implement-finality-check-for-the-get-transaction-status-method
Farber98
commented
Jul 4, 2024
| @@ -1474,7 +1469,7 @@ FROM ( | |||
| FOR UPDATE OF e1 | |||
| ) e0 | |||
| WHERE e0.id = evm.txes.id | |||
| RETURNING e0.id, e0.nonce`, ErrCouldNotGetReceipt, cutoff, chainID.String()) | |||
| RETURNING e0.id, e0.nonce`, ErrCouldNotGetReceipt, latestFinalizedBlockNum, chainID.String()) | |||
There was a problem hiding this comment.
Do we want HAVING max(evm.tx_attempts.broadcast_before_block_num) < $2 (latestFinalizedBlockNum) to be inclusive now?
amit-momin
force-pushed
the
BCI-3486-implement-finality-check-for-the-get-transaction-status-method
branch
from
5b18016 to
911d342
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Parts of the EVM TXM code still relies on
FinalityDepthregardless if the chain is enabled to use finality tags. Through this PR we are updating the code to utilize the head tracker’s latest finalized block instead ofFinalityDepth.Acceptance Criteria
FinalityDepthshould be removed to enable the use of finality tags.FinalityDepthfrom the EVM TXM codeTickets:
Requires:
Unblocks: