Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KS-370] Pass config from onchain registry to execute calls #13750

Merged
merged 17 commits into from
Jul 24, 2024

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Jul 3, 2024

https://smartcontract-it.atlassian.net/jira/software/c/projects/KS/boards/182?assignee=712020%3A25361daa-6eb8-4a03-9963-0264ac70a192

  • This passes config from the onchain capabilities registry to the capability itself, allowing some config settings (eg. deltaStage, schedule) to be specified as capability config, not as workflow config).
  • Refactor the registrysyncer: this now returns a LocalRegistry object on each sync iteration with methods for fetching the local node and capability-specific config.
  • Add methods from the LocalRegistry to the CapabilitiesRegistry as well, so they can be passed to LOOPified capabilities.

Requires Dependencies

smartcontractkit/chainlink-common#640

Resolves Dependencies

Copy link
Contributor

github-actions bot commented Jul 3, 2024

I see you updated files related to core. Please run pnpm changeset in the root directory to add a changeset as well as in the text include at least one of the following tags:

  • #added For any new functionality added.
  • #breaking_change For any functionality that requires manual action for the node to boot.
  • #bugfix For bug fixes.
  • #changed For any change to the existing functionality.
  • #db_update For any feature that introduces updates to database schema.
  • #deprecation_notice For any upcoming deprecation functionality.
  • #internal For changesets that need to be excluded from the final changelog.
  • #nops For any feature that is NOP facing and needs to be in the official Release Notes for the release.
  • #removed For any functionality/config that is removed.
  • #updated For any functionality that is updated.
  • #wip For any change that is not ready yet and external communication about it should be held off till it is feature complete.

@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 52e7740 to 339a2e2 Compare July 5, 2024 11:03
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 339a2e2 to b1258de Compare July 5, 2024 11:10
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from b1258de to 8962c0a Compare July 5, 2024 11:33
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 8962c0a to e6cc5bc Compare July 5, 2024 12:23
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from e6cc5bc to 0d57c83 Compare July 5, 2024 15:16
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 0d57c83 to 10f4e81 Compare July 5, 2024 15:22
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 7268bd5 to 2834005 Compare July 8, 2024 09:16
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 79ae6ee to 782be8b Compare July 8, 2024 11:59
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 782be8b to 65baa77 Compare July 8, 2024 12:49
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from ac27a38 to 040400e Compare July 8, 2024 13:01
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from 040400e to d5a59eb Compare July 8, 2024 13:07
@cedric-cordenier cedric-cordenier force-pushed the config-version-metadata branch from d5a59eb to ae1e391 Compare July 8, 2024 15:30
@cedric-cordenier cedric-cordenier dismissed stale reviews from ettec and HenryNguyen5 July 24, 2024 12:17

PR updated

@cedric-cordenier cedric-cordenier added this pull request to the merge queue Jul 24, 2024
Merged via the queue into develop with commit d777fd8 Jul 24, 2024
111 of 114 checks passed
@cedric-cordenier cedric-cordenier deleted the config-version-metadata branch July 24, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants