Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ChainComponents EVM Interface Tests #13735

Merged
merged 1 commit into from
Sep 5, 2024
Merged

ChainComponents EVM Interface Tests #13735

merged 1 commit into from
Sep 5, 2024

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Jul 1, 2024 •
edited
Loading

Description: Changes the ChainReader EVM Interface tests to use the ChainWriter instead of a helper and updates the simulated backend ChainReader tests to implement a TXM + ChainWriter

Corresponding ticket:

Requires Dependencies

Resolves Dependencies

@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from a1726df to 284f348 Compare July 9, 2024 14:04
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from a401a46 to 7250e06 Compare July 10, 2024 14:58
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from ed82175 to e6cc817 Compare July 11, 2024 14:32
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from e6cc817 to 06be4e0 Compare July 11, 2024 14:32
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from 06be4e0 to 8ece2c0 Compare July 11, 2024 14:33
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch 6 times, most recently from 35bc9a2 to 485439d Compare July 15, 2024 22:32
@silaslenihan silaslenihan changed the base branch from develop to BCI-3486-implement-finality-check-for-the-get-transaction-status-method July 15, 2024 22:32
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from 71db954 to 54dd89c Compare July 15, 2024 22:38
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from 54dd89c to c27ddf5 Compare July 15, 2024 22:38
@ilija42 ilija42 changed the base branch from ocr2vrf-flakey-test to develop September 5, 2024 14:24
@ilija42 ilija42 dismissed patrick-dowell’s stale review September 5, 2024 14:24

The base branch was changed.

@ilija42
Copy link
Contributor

ilija42 commented Sep 5, 2024

whats up with the commit history?

I believe Amit's commits are included in this PR because I was dependent on the Finazlier changes he was working on. While those were still in progress I based this branch on his branch. I'm not sure why they are still there though because I rebased on top of develop

HIs commits got squashed so when you rebase it doesn't recognize them

ilija42
ilija42 reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@ilija42 ilija42 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are effectively duplicating commit history although it will squash, but your squashed commit msg won't reflect the actual changes

@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch 4 times, most recently from b9c4b85 to 46b89ea Compare September 5, 2024 16:58
EasterTheBunny
EasterTheBunny previously approved these changes Sep 5, 2024
View reviewed changes
@silaslenihan silaslenihan force-pushed the cw-evm-interface-tests branch from 46b89ea to 1467436 Compare September 5, 2024 17:18
@ilija42 ilija42 enabled auto-merge September 5, 2024 17:35
@ilija42 ilija42 added this pull request to the merge queue Sep 5, 2024
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
2 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
5.4% Duplication on New Code

See analysis details on SonarQube

Merged via the queue into develop with commit 920413c Sep 5, 2024
134 checks passed
@ilija42 ilija42 deleted the cw-evm-interface-tests branch September 5, 2024 18:10
This was referenced Sep 5, 2024
Draft
Draft
@github-actions github-actions bot mentioned this pull request Sep 20, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolag nolag nolag left review comments

@ilija42 ilija42 ilija42 approved these changes

@EasterTheBunny EasterTheBunny EasterTheBunny approved these changes

@patrick-dowell patrick-dowell patrick-dowell left review comments

@kalverra kalverra Awaiting requested review from kalverra

@skudasov skudasov Awaiting requested review from skudasov

@AnieeG AnieeG Awaiting requested review from AnieeG

@chainchad chainchad Awaiting requested review from chainchad

@HenryNguyen5 HenryNguyen5 Awaiting requested review from HenryNguyen5

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@jmank88 jmank88 Awaiting requested review from jmank88

@samsondav samsondav Awaiting requested review from samsondav

@se3000 se3000 Awaiting requested review from se3000

@connorwstein connorwstein Awaiting requested review from connorwstein

@RyanRHall RyanRHall Awaiting requested review from RyanRHall

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@silaslenihan @ilija42 @nolag @patrick-dowell @EasterTheBunny