-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SHIP-1754 Consolidate FinalityDepth config #13702
Open
adityavadhavkar1215
wants to merge
31
commits into
develop
Choose a base branch
from
SHIP-1754-Consolidate-all-FinalityDepth-settings
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 25 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
fbaf4ea
Added missing FinalityDepth config in default toml files.
adityavadhavkar1215 5f1ede3
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 926e1f0
added changeset to the PR.
adityavadhavkar1215 5f2b8c8
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 dc4fb58
Updated docs/CONFIG.md
adityavadhavkar1215 7ff582c
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 1f32b48
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 703c28a
Updated test config to resolve test failure.
adityavadhavkar1215 d69c25b
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 74457d1
Updated the changeset tag to internal.
adityavadhavkar1215 b967bc7
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 ea5dc96
Addressed PR comments
adityavadhavkar1215 5ef0011
Merge branch 'SHIP-1754-Consolidate-all-FinalityDepth-settings' of gi…
adityavadhavkar1215 9cc0296
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 e384dcd
Updated test values.
adityavadhavkar1215 7ee2841
Merge branch 'SHIP-1754-Consolidate-all-FinalityDepth-settings' of gi…
adityavadhavkar1215 39b39d6
Updated default config for Ethereum testnets
adityavadhavkar1215 963a389
Updated values for chains that did not have default value
adityavadhavkar1215 d7a75bc
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
adityavadhavkar1215 38d8b58
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
Madalosso 864bc54
Revision: Testnet value from infra-k8s prod-testnet, mainnet from Nod…
Madalosso cfc08ec
save WIP
Madalosso 77ade09
Update chain defaults using ccip repo as source of truth
Madalosso 31c567b
gen docs
Madalosso 6c262e6
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
Madalosso e569490
revert artbitrum finalityDepth values
Madalosso e6865e1
Undo comment deletion
Madalosso e3f41f6
fixes
Madalosso 49c5f16
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
Madalosso 9132246
FinalityTagBypass setup for chains with FinalityDepth<1000
Madalosso 660f3ce
Merge branch 'develop' into SHIP-1754-Consolidate-all-FinalityDepth-s…
Madalosso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
"chainlink": patch | ||
--- | ||
|
||
#internal Added FinalityDepth config where it was missing |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
ChainID = '59141' | ||
FinalityDepth = 900 | ||
FinalityDepth = 200 | ||
NoNewHeadsThreshold = '0' | ||
|
||
[GasEstimator] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
ChainID = '592' | ||
ChainType = 'astar' | ||
FinalityTagEnabled = true | ||
FinalityDepth = 100 | ||
LogPollInterval = '6s' | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = false | ||
PriceMax = '100000 gwei' | ||
LimitDefault = 8000000 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
ChainID = '81' | ||
FinalityTagEnabled = true | ||
FinalityDepth = 100 | ||
LogPollInterval = '6s' | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = false | ||
PriceMax = '100000 gwei' | ||
LimitDefault = 8000000 |
19 changes: 19 additions & 0 deletions
19
core/chains/evm/config/toml/defaults/Avalanche_ANZ_testnet.toml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,19 @@ | ||
ChainID = '76578' | ||
FinalityDepth = 1 | ||
FinalityTagEnabled = false | ||
LinkContractAddress = '0x779877A7B0D9E8603169DdbD7836e478b4624789' | ||
LogPollInterval = '3s' | ||
MinIncomingConfirmations = 1 | ||
# Avax subnet only emits blocks when a new tx is received, so this method of liveness detection is not useful. | ||
NoNewHeadsThreshold = '0' | ||
OCR.ContractConfirmations = 1 | ||
RPCBlockQueryDelay = 2 | ||
|
||
[GasEstimator] | ||
Mode = 'BlockHistory' | ||
PriceDefault = '25 gwei' | ||
PriceMax = '115792089237316195423570985008687907853269984665.640564039457584007913129639935 tether' | ||
PriceMin = '25 gwei' | ||
|
||
[GasEstimator.BlockHistory] | ||
BlockHistorySize = 24 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
ChainID = '81457' | ||
FinalityDepth = 200 | ||
FinalityTagEnabled = true | ||
ChainType = 'optimismBedrock' | ||
# block rate is ~2sec, so this ensures blocks are polled correctly | ||
LogPollInterval = '2s' | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = true | ||
BumpThreshold = 60 | ||
BumpPercent = 20 | ||
BumpMin = '100 wei' | ||
PriceMax = '120 gwei' | ||
LimitDefault = 8000000 | ||
FeeCapDefault = '120 gwei' | ||
|
||
[GasEstimator.BlockHistory] | ||
# Default is 24, which leads to bumpy gas prices. In CCIP | ||
# we want to smooth out the gas prices, so we increase the sample size. | ||
BlockHistorySize = 200 | ||
# The formula for FeeCap is (current block base fee * (1.125 ^ EIP1559FeeCapBufferBlocks) + tipcap) | ||
# where tipcap is managed by the block history estimators. In the context of CCIP, | ||
# the gas price is relayed to other changes for quotes so we want accurate/avg not pessimistic values. | ||
# So we set this to zero so FeeCap = baseFee + tipcap. | ||
EIP1559FeeCapBufferBlocks = 0 | ||
|
||
[HeadTracker] | ||
HistoryDepth = 300 | ||
|
||
[NodePool] | ||
# 4 block sync time between nodes to ensure they aren't labelled unreachable too soon | ||
PollFailureThreshold = 4 | ||
# polls every 4sec to check if there is a block produced, since blockRate is ~3sec | ||
PollInterval = '4s' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
ChainID = '168587773' | ||
FinalityDepth = 200 | ||
FinalityTagEnabled = true | ||
ChainType = 'optimismBedrock' | ||
# block rate is ~2sec, so this ensures blocks are polled correctly | ||
LogPollInterval = '2s' | ||
|
||
[GasEstimator] | ||
EIP1559DynamicFees = true | ||
BumpThreshold = 60 | ||
BumpPercent = 20 | ||
BumpMin = '100 wei' | ||
PriceMax = '120 gwei' | ||
LimitDefault = 8000000 | ||
FeeCapDefault = '120 gwei' | ||
|
||
[GasEstimator.BlockHistory] | ||
# Default is 24, which leads to bumpy gas prices. In CCIP | ||
# we want to smooth out the gas prices, so we increase the sample size. | ||
BlockHistorySize = 200 | ||
# The formula for FeeCap is (current block base fee * (1.125 ^ EIP1559FeeCapBufferBlocks) + tipcap) | ||
# where tipcap is managed by the block history estimators. In the context of CCIP, | ||
# the gas price is relayed to other changes for quotes so we want accurate/avg not pessimistic values. | ||
# So we set this to zero so FeeCap = baseFee + tipcap. | ||
EIP1559FeeCapBufferBlocks = 0 | ||
|
||
[HeadTracker] | ||
HistoryDepth = 300 | ||
|
||
[NodePool] | ||
# 4 block sync time between nodes to ensure they aren't labelled unreachable too soon | ||
PollFailureThreshold = 4 | ||
# polls every 4sec to check if there is a block produced, since blockRate is ~3sec | ||
PollInterval = '4s' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
ChainID = '59141' | ||
FinalityDepth = 900 | ||
FinalityDepth = 200 | ||
NoNewHeadsThreshold = '0' | ||
|
||
[GasEstimator] | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@simsonraj please help