adding smoke tests for v23 #13644
Merged
adding smoke tests for v23 #13644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shileiwill
force-pushed
the
add_link_v23_test
branch
3 times, most recently
from
947c773 to
e23ef5b
Compare
shileiwill
force-pushed
the
add_link_v23_test
branch
from
e23ef5b to
11844e9
Compare
integration-tests/go.mod
Outdated
| github.com/scylladb/go-reflectx v1.0.1 | ||
| github.com/segmentio/ksuid v1.0.4 | ||
| github.com/shopspring/decimal v1.3.1 | ||
| github.com/slack-go/slack v0.12.2 | ||
| github.com/smartcontractkit/chainlink-automation v1.0.4 | ||
| github.com/smartcontractkit/chainlink-common v0.1.7-0.20240620164046-1c03d0a97b20 | ||
| github.com/smartcontractkit/chainlink-testing-framework v1.31.1 | ||
| github.com/smartcontractkit/chainlink-testing-framework v1.30.5 |
There was a problem hiding this comment.
@shileiwill can you undo this CTF downgrade change
There was a problem hiding this comment.
This also could be linked - https://github.com/smartcontractkit/chainlink/actions/runs/9609686757/job/26504664318?pr=13644#step:4:770
| Transcoder: common.Address{}, | ||
| Registrars: []common.Address{common.HexToAddress(registrar)}, | ||
| UpkeepPrivilegeManager: registryOwnerAddress, | ||
| ChainModule: chainModuleAddress, // TODO here is the chainModule |
There was a problem hiding this comment.
nit: what is this TODO?
There was a problem hiding this comment.
should be removed, good catch.
anirudhwarrier
requested changes
Jun 21, 2024
shileiwill
force-pushed
the
add_link_v23_test
branch
from
e885c68 to
bf3afad
Compare
shileiwill
force-pushed
the
add_link_v23_test
branch
from
bf3afad to
763af8e
Compare
shileiwill
force-pushed
the
add_link_v23_test
branch
from
763af8e to
a2ff55c
Compare
anirudhwarrier
approved these changes
Jun 21, 2024
|
FelixFan1992
approved these changes
Jun 21, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-9980
This PR adds integration test for Automation v23, using the LINK token and using Conditional upkeeps. Will add more use cases in following PRs, e.g. other ERC20 tokens and log trigger based upkeeps
The integration test passes.