Stop spamming logs when setting duplicate receiver #13560
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
force-pushed
the
logging-follow-up
branch
from
80b1450 to
f023169
Compare
cedric-cordenier
force-pushed
the
logging-follow-up
branch
from
f023169 to
4177e6d
Compare
bolekk
reviewed
Jun 18, 2024
bolekk
previously approved these changes
Jun 18, 2024
ettec
reviewed
Jun 19, 2024
| @@ -94,7 +99,7 @@ func (d *dispatcher) SetReceiver(capabilityId string, donId string, rec remotety | |||
| k := key{capabilityId, donId} | |||
| _, ok := d.receivers[k] | |||
| if ok { | |||
| return fmt.Errorf("receiver already exists for capability %s and don %s", capabilityId, donId) | |||
| return fmt.Errorf("%w: capability %s and don %s", ErrReceiverExists, capabilityId, donId) | |||
There was a problem hiding this comment.
nit: I would expect the caller to wrap/log this error with the capability ID etc (as it is doing), so no need to wrap the error at this point.
ettec
previously approved these changes
Jun 19, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* fix: bump sonarsource/sonarqube-scan-action to v2.3.0 * fix: increase memory for sonarscan action * fix: even more memory * fix: disable coverage redesign * Revert "fix: disable coverage redesign" This reverts commit 6155794. * fix: even more more memory
…ries (#13827) * [TT-1252] Make tools used in ci reusable for chainlink-integrations * Make fuzz reusable in other reops * Make the fuzz python arg for the root of the go project more readable as to its meaning
* use updated CTF * use tagged CTF * verify commit * fix compile error --------- Co-authored-by: Anirudh Warrier <[email protected]>
…chain writer (#13829) * evm: Use the transactionId as the idempotency key in the chainwriter * changeset: Add changeset tag --------- Co-authored-by: Silas Lenihan <[email protected]>
* Chain Reader Batch Call inital commit * Add batchCaller tests * Minor code improvement for ChainReader addDecoderDef and addEncoderDef * Use common types for Chain Reader BatchGetLatestValue * CR BatchGetLatestValue fixes and setup evm chain reader tester * Run lint, generate and update common ref * Add changeset * Update common ref, rename BatchGetLatestValue to BatchGetLatestValues * Import new common changes * Return an error if BatchGetLatestValues received an event in the req * Bump common * fix minor merge issues * Add common codec mock for batch_caller_test * Bump feeds * Bump Solana
* FunctionsCoordinator v1.3.1 * fix: add NPM token to fetch private repo * fix: use npm config set * revert * add auth credentials * add auth credentials * remove auth for npm --------- Co-authored-by: Pablo <[email protected]>
* add empty bal spec * add bal_spec_id * include ccip spec ids * remove orm changes * add changeset * add tag --------- Co-authored-by: Chris <[email protected]>
cedric-cordenier
requested review from
a team,
RensR,
archseer and
patrick-dowell
as code owners
|
I see you added a changeset file but it does not contain a tag. Please edit the text include at least one of the following tags:
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
Requires Dependencies
Resolves Dependencies