-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VRFV2Plus L1 fee calculation updates for Optimism and Base #13335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leeyikjiun
reviewed
May 29, 2024
ibrajer
changed the title
VRFV2Plus wrapper L1 fee calculation updates for Optimism and Base
VRFV2Plus L1 fee calculation updates for Optimism and Base
Jun 5, 2024
Quality Gate passedIssues Measures |
jinhoonbang
approved these changes
Jul 3, 2024
kidambisrinivas
approved these changes
Jul 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 4, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Jul 4, 2024
This was referenced Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Optimism provides a way of calculating L1 gas fees via a predeploy OracleGasPrice contract. Gas usage of this gas calculation function is too high. This is an attempt to reduce the cost for the customer, but also to provide several options to calculate L1 gas fees in the future (after the Fjord upgrade).
Overview of changes
The most major change for Optimism is incorporating three different versions of L1 fee calculation:
getL1Fee
function on predeploy OracleGasPrice contract (the most accurate one, but gas expensive)getL1FeeUpperBound
gas cost approximation on predeploy OracleGasPrice contract (upper bound calculation available after Fjord upgrade), this is used with having a pricing coefficient in mind to reduce overcharginggetL1Fee
calculation for Ecotone (with average payload data layout taken into account), this is used with having a pricing coefficient in mind to reduce overchargingThe changes above inspired (and forced) some other necessary changes to existing contracts:
VRFCoordinatorV2_5
andVRFV2PlusWrapper
contract to separate abstract contractsOptimismL1Fees
andAbritrumL1Fees
VRFV2PlusWrapper
contract in a new singleVRFV2PlusWrapperL1Fees
contract (replacingChainSpecificUtil
used before), abstracting this calculation away from theVRFV2PlusWrapper
VRFCoordinatorV2_5
contract)VRFCoordinatorV2_5_Optimism
doesn't break the contract size limit (thanks to @leeyikjiun)