Log dropping and block windows #12342
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
ferglor
reviewed
Mar 7, 2024
| func BlockWindow(block int64, blockRate int) (start int64, end int64) { | ||
| windowSize := int64(blockRate) | ||
| if windowSize == 0 { | ||
| return block, block |
There was a problem hiding this comment.
Should we return an error here/enforce non-zero windows?
There was a problem hiding this comment.
I'd rather validate it somewhere else but still prefer to check for zero here to avoid doing mod with 0
|
|
Will be merged with #12357 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-8985
Motivation
As part of rate limiting, we might need to drop logs. The dropping should be consistent across nodes, using a function that can be shared
Changes