Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update CI for changeset check #12212

Merged
merged 4 commits into from
Mar 7, 2024
Merged

Conversation

momentmaker
Copy link
Contributor

@momentmaker momentmaker commented Feb 28, 2024

This action checks PRs to see if any changeset files were added in the PR core files were changed. If none were, it will add a comment in the PR to run changeset command to generate a changeset file.

This should be merged after this PR has been merged:
#12198

Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@chainchad
Copy link
Collaborator

Would it make sense to use https://github.com/smartcontractkit/.github/tree/main/actions/guard-from-missing-changesets here and if not integrate what you need to that composite action?

@momentmaker
Copy link
Contributor Author

Would it make sense to use smartcontractkit/.github@main/actions/guard-from-missing-changesets here and if not integrate what you need to that composite action?

ahh I forgot it was there. I think this changeset guard is a bit different since we only want to filter out certain dir changes right?

also if we integrate the comment to pr action then we will need to integrate GATI into this composite action too right?

@momentmaker momentmaker marked this pull request as ready for review March 7, 2024 19:05
@momentmaker momentmaker requested review from a team as code owners March 7, 2024 19:05
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@chainchad chainchad added this pull request to the merge queue Mar 7, 2024
Merged via the queue into develop with commit 375ccb1 Mar 7, 2024
97 checks passed
@chainchad chainchad deleted the re-2263/update-ci-check-changeset branch March 7, 2024 20:36
ogtownsend pushed a commit that referenced this pull request Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants