-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-791] Migrate OCRv1/v2 tests from EVMClient to Seth #12076
Conversation
…they weren't used outside of OCR soak tests, renamed old Ethereum contracts to Legacy* (only ones reimplemented with Seth), removed unused methods from contract interfaces, added Seth to testconfig
…ogs to funds sendnig retriers
I see that you haven't updated any README files. Would it make sense to do so? |
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
numberOfContracts int, | ||
linkTokenContractAddress common.Address, | ||
workerNodes []*client.ChainlinkK8sClient, | ||
getTransmitterAndPayeesFn func() ([]string, []string, error), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious why we pass in functions for this instead of just asking for the data directly? Is it more concise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that this way we don't have copy & paste or encapsulate in yet another method the different codes that retrieve these addresses from nodes or forwarder contracts
Quality Gate passedIssues Measures |
What was done:
EVMClient
toLegacy*
_local
equivalents by introducing smallest possible surface interfaces that define methods common to local and k8s Chainlink client (because method signature was the only difference between two functions)General approach to migration:
Log created by funds returning retrier:
Sample WASP run logs: