split transmit into two functions to address stack too deep errrors #11977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
Go solidity wrappers are out-of-date, regenerate them via the |
RyanRHall
force-pushed
the
split-transmit-auto-2-2
branch
from
c4ebccc to
6d5f625
Compare
shileiwill
previously approved these changes
Feb 8, 2024
RyanRHall
force-pushed
the
split-transmit-auto-2-2
branch
from
6d5f625 to
a9bdc0d
Compare
RyanRHall
force-pushed
the
split-transmit-auto-2-2
branch
from
a9bdc0d to
c07eb49
Compare
|
SonarQube Quality Gate
|
shileiwill
approved these changes
Feb 8, 2024
shileiwill
reviewed
Feb 8, 2024
| gasOverhead = | ||
| (gasOverhead - gasleft() + 16 * rawReport.length) + | ||
| (gasOverhead - gasleft() + 16 * msg.data.length) + |
There was a problem hiding this comment.
just out of curiousity, msg.data and rawReport are equivalent?
There was a problem hiding this comment.
nope! definitely not. I made this change (and a bunch of other changes) in a separate PR, but I included it here too just to make the refactor cleaner.
There was a problem hiding this comment.
you can see the comment I added above
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.