Override RpcDefaultBatchSize for Polygon #11962
Conversation
Default batch size setting in geth is 250, but for polygon's client bor it's 100 Setting it to 250 on our side causes bor to give invalid responses back
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
I see that you haven't updated any README files. Would it make sense to do so? |
| @@ -4,6 +4,7 @@ NoNewHeadsThreshold = '6m' | |||
| MinIncomingConfirmations = 1 | |||
| LogPollInterval = '30s' | |||
| RPCBlockQueryDelay = 15 | |||
| RPCDefaultBatchSize = 100 | |||
There was a problem hiding this comment.
It might not be relevant since we lower the limit but it would be nice to confirm that Polygon zkEVM behaves the same way as L1 since it's a rollup and it might deviate from the original RPC client.
There was a problem hiding this comment.
Can't find the default but I found these values: https://github.com/0xPolygonHermez/zkevm-node/blob/9ef6f20949dfd4533fb64af2d1dfd012d8dbeba8/jsonrpc/config.go#L41-L45
There was a problem hiding this comment.
Found the default: https://github.com/0xPolygonHermez/zkevm-node/blob/54ef1c4ad600b396442ac2c2263594a80a10f45b/config/default.go#L90 seems to be 20.
|
SonarQube Quality Gate
|
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
* Override RpcDefaultBatchSize for Polygon Default batch size setting in geth is 250, but for polygon's client bor it's 100 Setting it to 250 on our side causes bor to give invalid responses back * fix test * fix more tests --------- Co-authored-by: Makram Kamaleddine <[email protected]>
Default batch size setting in geth is 250, but for polygon's client bor it's 100 Setting it to 250 on our side causes bor to give invalid responses back