update Fantom defaults: PriceMin = '0' #11882
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
samsondav
previously approved these changes
Jan 24, 2024
prashantkumar1982
previously approved these changes
Jan 24, 2024
|
Todo:
|
|
@jmank88 can we go forward with this PR now please? The config testing indicated no issues with disabling the Bump threshold. |
|
I think it will probably just be closed now since bumping support was added in the other PR, so this is no longer correct |
|
@jmank88 do you mean via PR #11805 ? Shouldn't we still disable the bump for FTM based on @dimriou 's comment here . Even though we won't see bumping errors on FTM it might still not include txs if the bumped price is not same as what their api suggested |
jmank88
dismissed stale reviews from prashantkumar1982 and samsondav
via
30da020
jmank88
changed the title
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.