.github/workflows: notify slack for ci-core develop failures #11408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
changed the title
|
SonarQube Quality Gate
|
vyzaldysanchez
approved these changes
Nov 29, 2023
| @@ -29,7 +29,7 @@ jobs: | |||
| gc-basic-auth: ${{ secrets.GRAFANA_CLOUD_BASIC_AUTH }} | |||
| gc-host: ${{ secrets.GRAFANA_CLOUD_HOST }} | |||
| - name: Notify Slack | |||
| if: ${{ failure() && github.event.schedule != '' }} | |||
| if: ${{ failure() && (github.event_name == 'merge_group' || github.event.branch == 'develop')}} | |||
There was a problem hiding this comment.
Would it be easier to invert this and to instead ignore any pull request events?
There was a problem hiding this comment.
I was worried about including release and master since we sometimes have weird situations there.
HenryNguyen5
approved these changes
Nov 29, 2023
jmank88
requested review from
chainchad,
javuto,
jkongie and
samsondav
as code owners
fbac
pushed a commit
that referenced
this pull request
Dec 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we pushed slack notifications for linter failures and data races for nightly scheduled runs only. This PR expands notifications to all develop and merge queue jobs.