Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-2779] Prettier storage of config for Operator UI #11406

Merged
merged 1 commit into from
Nov 30, 2023
Merged

[BCF-2779] Prettier storage of config for Operator UI #11406

merged 1 commit into from
Nov 30, 2023

Conversation

cedric-cordenier
Copy link
Contributor

@cedric-cordenier cedric-cordenier commented Nov 29, 2023 •
edited
Loading

  • Don't store the pluginConfig as a string inside the job spec, instead store it as rich TOML
  • Add the pipeline that comes from observationSource to the pipeline specs we pass to reporting plugin; this is so that we display the primary pipeline spec correctly in Operator UI.

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@cedric-cordenier cedric-cordenier force-pushed the BCF-2779-prettier-config-formatting branch 2 times, most recently from a15cca4 to d37742d Compare November 29, 2023 14:16
@cedric-cordenier cedric-cordenier force-pushed the BCF-2779-prettier-config-formatting branch from d37742d to 290f72a Compare November 29, 2023 14:31
@cedric-cordenier cedric-cordenier changed the title Bcf 2779 prettier config formatting [BCF-2779] Prettier storage of config for Operator UI Nov 29, 2023
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate failed

Failed condition 33.3% 33.3% Coverage on New Code (is less than 75%)

See analysis details on SonarQube

@cedric-cordenier cedric-cordenier marked this pull request as ready for review November 29, 2023 15:16
@cedric-cordenier cedric-cordenier added this pull request to the merge queue Nov 30, 2023
Merged via the queue into develop with commit 0ae8279 Nov 30, 2023
87 of 88 checks passed
@cedric-cordenier cedric-cordenier deleted the BCF-2779-prettier-config-formatting branch November 30, 2023 09:25
fbac pushed a commit that referenced this pull request Dec 14, 2023
@cedric-cordenier
[BCF-2779] Better formatting of the generic plugin config (#11406)
01f8398
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@krehermann krehermann Awaiting requested review from krehermann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cedric-cordenier @jmank88