Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dependencies on services package in common #11321

Merged
merged 3 commits into from
Nov 21, 2023
Merged

Remove dependencies on services package in common #11321

merged 3 commits into from
Nov 21, 2023

Conversation

amit-momin
Copy link
Contributor

Updated the common package to use dependencies that do not rely on imports from core services

  • Updated the use of the ServiceCtx from services to directly use the chainlink-relay
  • Update the use of pg/datatypes JSON to directly using the encoding/json json.RawMessage
  • Removed reference to pg.Queryer in unused type

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@amit-momin amit-momin force-pushed the evm-extraction-services-package branch 2 times, most recently from 57ed7a0 to d219cab Compare November 20, 2023 22:48
@amit-momin amit-momin mentioned this pull request Nov 21, 2023
Merged
@amit-momin amit-momin force-pushed the evm-extraction-services-package branch 4 times, most recently from 868062f to c3b995e Compare November 21, 2023 18:26
@amit-momin amit-momin marked this pull request as ready for review November 21, 2023 18:49
@amit-momin amit-momin requested review from dimriou and removed request for samsondav and RyanRHall November 21, 2023 18:50
@amit-momin amit-momin force-pushed the evm-extraction-services-package branch from b27f75f to bc026b7 Compare November 21, 2023 20:25
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@prashantkumar1982 prashantkumar1982 added this pull request to the merge queue Nov 21, 2023
Merged via the queue into develop with commit aca537d Nov 21, 2023
88 checks passed
@prashantkumar1982 prashantkumar1982 deleted the evm-extraction-services-package branch November 21, 2023 22:20
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashantkumar1982 prashantkumar1982 prashantkumar1982 approved these changes

@jmank88 jmank88 jmank88 approved these changes

@dimriou dimriou Awaiting requested review from dimriou

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amit-momin @jmank88 @prashantkumar1982