Adds a codec and makes chain reader use it. #11303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
nolag
force-pushed
the
rtinianov_sizes
branch
from
38a06f9 to
17bd691
Compare
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
0377150 to
2f4c4d9
Compare
nolag
force-pushed
the
rtinianov_sizes
branch
from
17bd691 to
786c2d4
Compare
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
2f4c4d9 to
002dedf
Compare
nolag
force-pushed
the
rtinianov_sizes
branch
from
786c2d4 to
2039176
Compare
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
002dedf to
3b9d0c1
Compare
nolag
force-pushed
the
rtinianov_sizes
branch
from
2039176 to
85f0a93
Compare
nolag
requested review from
jmank88,
krehermann,
a team,
bolekk,
justinkaseman and
KuphJr
nolag
force-pushed
the
rtinianov_sizes
branch
from
85f0a93 to
549ba37
Compare
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
3b9d0c1 to
e4c8cdc
Compare
nolag
force-pushed
the
rtinianov_sizes
branch
from
549ba37 to
712a010
Compare
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
e4c8cdc to
3b1c28c
Compare
nolag
force-pushed
the
rtinianov_sizes
branch
2 times, most recently
from
327534f to
1690e14
Compare
Base automatically changed from
rtinianov_sizes
to
BCF-2612-ChainReader-Next
November 28, 2023 20:47
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
3b1c28c to
c89d452
Compare
nolag
changed the title
nolag
force-pushed
the
rtinianov_encode_decode
branch
6 times, most recently
from
5373a97 to
9f0a79c
Compare
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
9f0a79c to
818cd08
Compare
| @@ -0,0 +1,60 @@ | |||
| // SPDX-License-Identifier: MIT | |||
| pragma solidity ^0.8; | |||
There was a problem hiding this comment.
+1 for testing this with an actual test smart contract! This is great :-)
…oth chain reader and codec.
nolag
force-pushed
the
rtinianov_encode_decode
branch
from
818cd08 to
103a8c5
Compare
|
SonarQube Quality Gate
|
reductionista
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a codec and makes chain reader use it.