Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use resty as http response in E2E tests and fix if testing.T context is nil #11271

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Use resty as http response in E2E tests and fix if testing.T context is nil #11271

merged 3 commits into from
Nov 14, 2023

Conversation

lukaszcl
Copy link
Collaborator

@lukaszcl lukaszcl commented Nov 13, 2023 •
edited
Loading

@lukaszcl lukaszcl changed the title Use resty as http response Use resty as http response in E2E tests Nov 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any README files. Would it make sense to do so?

@github-actions GitHub Actions
Copy link
Contributor

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@lukaszcl lukaszcl force-pushed the e2e-tests-use-resty-in-response branch from edd2402 to c1d32c5 Compare November 13, 2023 20:19
@lukaszcl lukaszcl changed the title Use resty as http response in E2E tests Use resty as http response in E2E tests and fix if testing.T context is nil Nov 14, 2023
@lukaszcl lukaszcl marked this pull request as ready for review November 14, 2023 12:03
@lukaszcl lukaszcl requested review from a team as code owners November 14, 2023 12:03
@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lukaszcl lukaszcl enabled auto-merge November 14, 2023 12:17
Tofel
Tofel approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@Tofel Tofel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@lukaszcl lukaszcl added this pull request to the merge queue Nov 14, 2023
Merged via the queue into develop with commit ac94719 Nov 14, 2023
87 checks passed
@lukaszcl lukaszcl deleted the e2e-tests-use-resty-in-response branch November 14, 2023 12:33
@snehaagni snehaagni mentioned this pull request Jan 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tofel Tofel Tofel approved these changes

@skudasov skudasov skudasov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukaszcl @skudasov @Tofel