[DO NOT MERGE] Functions 1.1 review #11252
Conversation
|
I see that you haven't updated any README files. Would it make sense to do so? |
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
|
Go solidity wrappers are out-of-date, regenerate them via the |
|
SonarQube Quality Gate
|
| } | ||
| if (destinationNoLongerExists) { | ||
| // solidity calls check that a contract actually exists at the destination, so we do the same | ||
| if (client.code.length == 0) { |
There was a problem hiding this comment.
reduced stack size so forge coverage could run
| @@ -377,8 +377,7 @@ contract FunctionsRouter is IFunctionsRouter, FunctionsSubscriptions, Pausable, | |||
| commitment.estimatedTotalCostJuels, | |||
| commitment.client, | |||
| commitment.adminFee, | |||
| juelsPerGas, | |||
| SafeCast.toUint96(result.gasUsed), | |||
| juelsPerGas * SafeCast.toUint96(result.gasUsed), | |||
There was a problem hiding this comment.
Making a breaking Router change like this would mean maintaining and deploying two different Coordinators, since existing networks won't be receiving a Router update for the next scheduled deployment
There was a problem hiding this comment.
Yeah called that out in the doc, probably ok to backlog until you'd be doing a v2
No description provided.