Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core/config: add EVM.OCR DeltaCOverride and DeltaCJitterOverride #11250

Merged
merged 3 commits into from
Nov 28, 2023

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Nov 9, 2023

https://smartcontract-it.atlassian.net/browse/BCF-2790

This PR adds EVM.OCR DeltaCOverride and DeltaCJitterOverride to TOML config for overriding the ConfigOverrider defaults, and changes the defaults from 24h/1h to 7d/1h.


DeltaCOverride

⚠️ ADVANCED: Do not change this setting unless you know what you are doing.

DeltaCOverride = "168h" # Default

DeltaCOverride (and DeltaCJitterOverride) determine the config override DeltaC.
DeltaC is the maximum age of the latest report in the contract. If the maximum age is exceeded, a new report will be
created by the report generation protocol.

DeltaCJitterOverride

⚠️ ADVANCED: Do not change this setting unless you know what you are doing.

DeltaCJitterOverride = "1h" # Default

DeltaCJitterOverride is the range for jitter to add to DeltaCOverride.

Copy link
Contributor

github-actions bot commented Nov 9, 2023

I see that you haven't updated any README files. Would it make sense to do so?

Copy link
Contributor

github-actions bot commented Nov 9, 2023

I see that you haven't updated any CHANGELOG files. Would it make sense to do so?

@jmank88 jmank88 force-pushed the config-overrider-defaults branch from 89306cf to 58292b7 Compare November 13, 2023 19:51
@jmank88 jmank88 changed the title core/config: add OCR DeltaC and DeltaCJitter core/config: add EVM.OCR OverrideDeltaC and OverrideDeltaCJitter Nov 14, 2023
@jmank88 jmank88 force-pushed the config-overrider-defaults branch 4 times, most recently from 4f25912 to 0ac829e Compare November 14, 2023 17:43
@jmank88 jmank88 changed the title core/config: add EVM.OCR OverrideDeltaC and OverrideDeltaCJitter core/config: add EVM.OCR DeltaCOverride and DeltaCJitterOverride Nov 14, 2023
@jmank88 jmank88 force-pushed the config-overrider-defaults branch from 0ac829e to 43bff4a Compare November 16, 2023 15:08
@jmank88 jmank88 force-pushed the config-overrider-defaults branch 7 times, most recently from 6e30214 to 00702c5 Compare November 27, 2023 14:25
@jmank88 jmank88 requested review from kaleofduty and a team November 27, 2023 14:28
@jmank88 jmank88 marked this pull request as ready for review November 27, 2023 14:40
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Do we want a CHANGELOG entry?

@jmank88
Copy link
Contributor Author

jmank88 commented Nov 27, 2023

LGTM! Do we want a CHANGELOG entry?

Oh yeah, I thought I had added one already. Incoming.

patrickhuie19
patrickhuie19 previously approved these changes Nov 27, 2023
@jmank88 jmank88 enabled auto-merge November 28, 2023 18:33
@jmank88 jmank88 added this pull request to the merge queue Nov 28, 2023
@cl-sonarqube-production
Copy link

Merged via the queue into develop with commit 9efb47d Nov 28, 2023
88 checks passed
@jmank88 jmank88 deleted the config-overrider-defaults branch November 28, 2023 21:51
fbac pushed a commit that referenced this pull request Dec 14, 2023
)

* core/config: add EVM.OCR OverrideDeltaC and OverrideDeltaCJitter

* update changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants