Devspace update + Cluster dashboard #11222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
skudasov
commented
Nov 7, 2023
•
skudasov
commented
- Fix devspace chart to use latest valid CL node params
- Add minimal Grafana dashboard as a go.mod
- Fix PodMonitor to work with latest Grafana
# Conflicts: # integration-tests/go.mod # integration-tests/go.sum
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
skudasov
force-pushed
the
devspace-update
branch
from
be0c2b4 to
a3d3277
Compare
skudasov
force-pushed
the
devspace-update
branch
from
335ce79 to
1efed0a
Compare
skudasov
force-pushed
the
devspace-update
branch
from
1abe26e to
bc2b6c7
Compare
|
SonarQube Quality Gate
|
kalverra
approved these changes
Nov 16, 2023
| func main() { | ||
| name := os.Getenv("DASHBOARD_NAME") | ||
| if name == "" { | ||
| panic("DASHBOARD_NAME must be provided") |
There was a problem hiding this comment.
Nit: Maybe use a fatal log or something instead? I'm not a huge fan of using panics this way, as it has a confusing layout for errors like this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.