Eth2 showcase with log poller #11214
Conversation
Tofel
changed the base branch from
develop
to
log_poller_streamline_on_demand
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
| func (te *CLClusterTestEnv) StartGeth() (blockchain.EVMNetwork, test_env.InternalDockerUrls, error) { | ||
| return te.Geth.StartContainer() | ||
| func (te *CLClusterTestEnv) StartEthereumNetwork(b *test_env.EthereumNetworkBuilder) (blockchain.EVMNetwork, test_env.RpcProvider, test_env.EthereumNetworkConfig, error) { | ||
| // if environment is being restored from a previous state, use the existing config |
There was a problem hiding this comment.
do we need this provision? is there any use case for it already?
There was a problem hiding this comment.
not yet, but I didn't want to break what we had there, because it allowed to re-use existing configuration (even if we never did it)
| Geth GethConfig `json:"geth"` | ||
| MockAdapter MockAdapterConfig `json:"mock_adapter"` | ||
| ClCluster *ClCluster `json:"clCluster"` | ||
| Networks []string `json:"networks"` |
There was a problem hiding this comment.
should we change this to toml? in case in future we want to pass this from test input toml ?
There was a problem hiding this comment.
we should! but I think we need to move the CTF config first and then we can move product-specific test configs?
|
SonarQube Quality Gate
|
skudasov
changed the title
Shows how to use new proposed Ethereum Network Builder using a log poller test. And how to make it backward compatible with existing tests that just use
GethwithPoW.