BCF-2654 chain reader evm poc get latest value impl #11176
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add some initialization and validation relay skeletons
This avoids us having to modify the signature of NewMedianFactory, which would require further modifications to all non-evm repos and chainlink-relay
Co-authored-by: Jordan Krage <[email protected]>
Logic was inverted here, causing ChainReader to be used if it's unimplemented rather than if it's implemeneted. Also, clarify error message to avoid ambiguity
This was getting setting medianProvider.chainReader to *chainReader(nil) instead of nil
|
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
Logic was inverted here, causing ChainReader to be used if it's unimplemented rather than if it's implemeneted. Also, clarify error message to avoid ambiguity
This was getting setting medianProvider.chainReader to *chainReader(nil) instead of nil
reductionista
force-pushed
the
BCF-2612-ChainReader-EVM-POC
branch
from
49ffeae to
790a5d9
Compare
…s/relay/evm/chain_reader.go
…to BCF-2654-ChainReader-EVM-POC-GetLatestValue # Conflicts: # core/services/ocr2/plugins/median/services.go # core/services/relay/evm/chain_reader.go # core/services/relay/evm/chain_reader_test.go # core/services/relay/evm/types/types.go # go.mod # go.sum # integration-tests/go.mod # integration-tests/go.sum
reductionista
force-pushed
the
BCF-2612-ChainReader-EVM-POC
branch
2 times, most recently
from
3a88d4c to
7fce04a
Compare
…to BCF-2654-ChainReader-EVM-POC-GetLatestValue # Conflicts: # core/services/relay/evm/chain_reader.go # core/services/relay/evm/chain_reader_test.go # core/services/relay/evm/types/types.go # integration-tests/go.sum
|
SonarQube Quality Gate
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.