add an empty index.html under core/web/assets to avoid running make #11114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-6903
Context:
I am working on this debugging script for our customers which is triggered by cli, e.g. cd to core/script/chaincli and then
go run main.go keeper debug 96601733428484125246719907842312606900925034674711094396763910645276293996221 0x5a51a2cf2283b1d4a075011c5e51308d4a34638e3ca00accc5f5ed2a71633ffe 5
The problem is: When running the above command, it complains
../../web/middleware.go:24:12: pattern assets: no matching files found
. Digging in, I figured it is from this//go:embed "assets"
directive in middleware.go. (I got your name from the history of this file 🙂 )Solutions are:
make test_need_operator_assets
and generate the index.html under core/web/assets, but this is not preferred as customers need to run this manually.This PR:
Per talking to Makram, there is no option 3, they've been using this make command
make operator-ui
. So, to avoid letting users run a unrelated make command, we go with option 2, which is this PR to add an empty index.html file to bypass the check.