-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUTO-6622 Enable v0.3 StreamsLookup to also use blockNumber #10986
Merged
cmalec
merged 5 commits into
develop
from
AUTO-6622-Enable-Mercury-v0.3-StreamsLookup-to-also-use-blockNumber
Oct 18, 2023
Merged
AUTO-6622 Enable v0.3 StreamsLookup to also use blockNumber #10986
cmalec
merged 5 commits into
develop
from
AUTO-6622-Enable-Mercury-v0.3-StreamsLookup-to-also-use-blockNumber
Oct 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I see that you haven't updated any README files. Would it make sense to do so? |
I see that you haven't updated any CHANGELOG files. Would it make sense to do so? |
infiloop2
reviewed
Oct 17, 2023
infiloop2
reviewed
Oct 17, 2023
…up-to-also-use-blockNumber
ferglor
reviewed
Oct 18, 2023
core/services/ocr2/plugins/ocr2keeper/evm21/streams_lookup_test.go
Outdated
Show resolved
Hide resolved
…up-to-also-use-blockNumber
ogtownsend
previously approved these changes
Oct 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like all comments have been resolved
core/services/ocr2/plugins/ocr2keeper/evm21/streams_lookup_test.go
Outdated
Show resolved
Hide resolved
ogtownsend
approved these changes
Oct 18, 2023
SonarQube Quality Gate |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Oct 18, 2023
cmalec
deleted the
AUTO-6622-Enable-Mercury-v0.3-StreamsLookup-to-also-use-blockNumber
branch
October 18, 2023 22:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update StreamsLookup so a user can use combination of feedIDs and blockNumber in addition to feedIDs and timestamp to call v0.3