shadow: declaration of X shadows declaration at line 913 (govet) #10890
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see that you haven't updated any README files. Would it make sense to do so? |
jmank88
force-pushed
the
golangci-lint-2023-10-09
branch
from
4dba2d6 to
b264c8e
Compare
jmank88
force-pushed
the
golangci-lint-2023-10-09
branch
4 times, most recently
from
54c9376 to
5cc92db
Compare
jmank88
force-pushed
the
golangci-lint-2023-10-09
branch
from
5cc92db to
415eaf5
Compare
|
SonarQube Quality Gate
|
cedric-cordenier
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve some cases directly, and simplify
NewEthConfirmerwhich always returned nil error, and which indirectly avoids some shadowing cases as well.