Add reentrancy guard to VRFCoordinatorV2Mock to align its behaviour w…

[kidambisrinivas]

Motivation

• Currently, VRFCoordinatorV2Mock contract does not completely mimic the behaviour of VRFCoordinatorV2 as it does not have Reentrancy Guard
• This would lead to issues during automated and manual testing

Solution

• Introduce Reentrancy Guard in VRFCoordinatorV2Mock to align its behaviour with VRFCoordinatorV2

Testing

$ pnpm hardhat test --grep VRFCoordinatorV2Mock
...
  VRFCoordinatorV2Mock
    #createSubscription
      ✔ can create a subscription
      ✔ subscription id increments
    #addConsumer
      ✔ can add a consumer to a subscription
      ✔ cannot add a consumer to a nonexistent subscription
      ✔ cannot add more than the consumer maximum (1042ms)
    #removeConsumer
      ✔ can remove a consumer from a subscription
      ✔ cannot remove a consumer from a nonexistent subscription
      ✔ cannot remove a consumer after it is already removed
    #fundSubscription
      ✔ can fund a subscription (42ms)
      ✔ cannot fund a nonexistent subscription
    #cancelSubscription
      ✔ can cancel a subscription (41ms)
    #fulfillRandomWords
      ✔ fails to fulfill without being a valid consumer
      ✔ fails to fulfill with insufficient funds (58ms)
      ✔ can request and fulfill [ @skip-coverage ]
      ✔ Correctly allows for user override of fulfillRandomWords [ @skip-coverage ]


               ⛳ Baseline gas used   : 641560 gas

               Current gas used   : 0 gas

               🚩 Delta : -641560 gas

               ⛳ Par   : 721271 gas

               🏌️  You   : 0 gas

               🚩 Score : -721271 gas

  15 passing (15s)

[github-actions]

I see that you haven't updated any README files. Would it make sense to do so?

[github-actions]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149669844

[github-actions]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6149694705

[vreff]

If you have the time, some foundry tests on the mockfile could be nice. However, I don't think it's worth the effort ever adding typescript/hardhat tests, since we don't really plan on working with that software going forward.

[kidambisrinivas]

Sure, I'll try to add Foundry tests for VRFCoordinatorV2Mock. Shall I add it as a follow up PR to this?

[github-actions]

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152766449

[cl-sonarqube-production]

SonarQube Quality Gate

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication