Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix golangci-lint #10555

Merged
merged 4 commits into from
Sep 12, 2023
Merged

Fix golangci-lint #10555

merged 4 commits into from
Sep 12, 2023

Conversation

HenryNguyen5
Copy link
Contributor

@HenryNguyen5 HenryNguyen5 commented Sep 7, 2023 •
edited
Loading

  • Adds coloured-line-output, which should give us better linting output
  • Fixes linter errors not being caught within test files from silent compilation failures
  • Simplifies linter workflow, with a larger runner we dont really need to worry about running the linter too often, better to keep it simple in this case. Having a 3 job deep dependency tree removed significantly speeds up linter time.

@HenryNguyen5 HenryNguyen5 force-pushed the fix/golint branch 14 times, most recently from 6768a05 to c196d7b Compare September 11, 2023 20:55
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6151676955

@HenryNguyen5 HenryNguyen5 force-pushed the fix/golint branch 2 times, most recently from e50e84c to 8bc6a0e Compare September 11, 2023 21:07
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6151796317

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6151938611

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152015257

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152034419

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152072183

@HenryNguyen5 HenryNguyen5 force-pushed the fix/golint branch 2 times, most recently from 4bac946 to 9546f1f Compare September 11, 2023 21:51
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152150721

@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6152153395

@HenryNguyen5 HenryNguyen5 requested a review from a team as a code owner September 12, 2023 14:04
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6160587704

samsondav
samsondav previously approved these changes Sep 12, 2023
View reviewed changes
@samsondav samsondav added this pull request to the merge queue Sep 12, 2023
chainchad
chainchad previously approved these changes Sep 12, 2023
View reviewed changes
jmank88
jmank88 previously approved these changes Sep 12, 2023
View reviewed changes
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 12, 2023
@jmank88 jmank88 added this pull request to the merge queue Sep 12, 2023
@HenryNguyen5 HenryNguyen5 removed this pull request from the merge queue due to a manual request Sep 12, 2023
@HenryNguyen5 HenryNguyen5 dismissed stale reviews from jmank88, chainchad, and samsondav via 01167ad September 12, 2023 16:16
@github-actions
Copy link
Contributor

Running downstream job at https://github.com/smartcontractkit/operator-ui/actions/runs/6162143606

@cl-sonarqube-production
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jmank88 jmank88 added this pull request to the merge queue Sep 12, 2023
Merged via the queue into develop with commit 645a6f3 Sep 12, 2023
@jmank88 jmank88 deleted the fix/golint branch September 12, 2023 18:35
@snehaagni snehaagni mentioned this pull request Oct 18, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmank88 jmank88 jmank88 approved these changes

@chainchad chainchad chainchad left review comments

@javuto javuto Awaiting requested review from javuto

@jkongie jkongie Awaiting requested review from jkongie

@samsondav samsondav Awaiting requested review from samsondav

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HenryNguyen5 @jmank88 @samsondav @chainchad