Merge branch 'develop' into BCI-4097-Update-the-TXM-confirmation-logi…

…c-to-use-the-mined-nonce

.changeset/eighty-bulldogs-smile.md

@@ -0,0 +1,5 @@
+---
+"chainlink": minor
+---
+
+#added Use ApplyDefaultsAndValidate

.changeset/moody-trains-grow.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+#added graceful shutdown for ccip oracles

.changeset/orange-humans-laugh.md

@@ -0,0 +1,5 @@
+---
+"chainlink": minor
+---
+
+Support Zircuit fraud transactions detection and zk overflow detection #added

.changeset/smooth-queens-dance.md

@@ -0,0 +1,5 @@
+---
+"chainlink": minor
+---
+
+Add compute capability #internal

.changeset/three-otters-drum.md

@@ -0,0 +1,5 @@
+---
+"chainlink": patch
+---
+
+Hedera chain type: broadcast transactions only to a single healthy RPC instead of all healthy RPCs to avoid redundant relay fees. #changed

.github/workflows/llm-action-error-reporter.yml

@@ -0,0 +1,24 @@
+name: LLM Action Error Reporter
+on:
+ workflow_run:
+ workflows: ["CI Core"] # This workflow will be triggered as soon as one of worfklows is completed
+ types:
+ - completed
+
+jobs:
+ analyze_logs:
+ runs-on: ubuntu-latest
+ permissions:
+ contents: read
+ pull-requests: write
+ repository-projects: read
+ actions: read
+ steps: 
+ - name: Analyze logs
+ uses: smartcontractkit/.github/actions/llm-action-error-reporter@5efdd03d4a3311e7a0954e5b3061dbb57596ca10 # v0.2.0
+ with:
+ parent-workflow-conclusion: ${{ github.event.workflow_run.conclusion }}
+ edit-comment: true
+ gh-token: ${{ secrets.GITHUB_TOKEN }}
+ openai-model: 'gpt-4-turbo-2024-04-09'
+ openai-api-key: ${{ secrets.OPENAI_API_KEY }}

.gitignore

@@ -109,3 +109,5 @@ override*.toml
 ocr_soak_report.csv
 
 vendor/*
+
+*.wasm

.golangci.yml

@@ -58,9 +58,6 @@ linters-settings:
  - (github.com/smartcontractkit/chainlink-common/pkg/logger.SugaredLogger).AssumptionViolationf
  - (github.com/smartcontractkit/chainlink-common/pkg/logger.SugaredLogger).Tracef
  - (github.com/smartcontractkit/chainlink-common/pkg/logger.SugaredLogger).Criticalf
- errorlint:
- # Allow formatting of errors without %w
- errorf: false
  revive:
  confidence: 0.8
  rules:

core/capabilities/ccip/ccip_integration_tests/usdcreader/usdcreader_test.go

@@ -11,6 +11,7 @@ import (
  "github.com/ethereum/go-ethereum/common"
  "github.com/ethereum/go-ethereum/core"
  "github.com/ethereum/go-ethereum/crypto"
+
  "github.com/smartcontractkit/chainlink-common/pkg/utils/tests"
 
  "github.com/stretchr/testify/assert"
@@ -19,7 +20,6 @@ import (
 
  sel "github.com/smartcontractkit/chain-selectors"
 
- "github.com/smartcontractkit/chainlink-ccip/execute/exectypes"
  "github.com/smartcontractkit/chainlink-ccip/pkg/contractreader"
  "github.com/smartcontractkit/chainlink-ccip/pkg/reader"
  "github.com/smartcontractkit/chainlink-ccip/pluginconfig"
@@ -74,97 +74,97 @@ func Test_USDCReader_MessageHashes(t *testing.T) {
 
  tt := []struct {
  name string
- tokens map[exectypes.MessageTokenID]cciptypes.RampTokenAmount
+ tokens map[reader.MessageTokenID]cciptypes.RampTokenAmount
  sourceChain cciptypes.ChainSelector
  destChain cciptypes.ChainSelector
- expectedMsgIDs []exectypes.MessageTokenID
+ expectedMsgIDs []reader.MessageTokenID
  }{
  {
  name: "empty messages should return empty response",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{},
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{},
  sourceChain: ethereumChain,
  destChain: avalancheChain,
- expectedMsgIDs: []exectypes.MessageTokenID{},
+ expectedMsgIDs: []reader.MessageTokenID{},
  },
  {
  name: "single token message",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{
- exectypes.NewMessageTokenID(1, 1): {
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{
+ reader.NewMessageTokenID(1, 1): {
  ExtraData: reader.NewSourceTokenDataPayload(11, ethereumDomainCCTP).ToBytes(),
  },
  },
  sourceChain: ethereumChain,
  destChain: avalancheChain,
- expectedMsgIDs: []exectypes.MessageTokenID{exectypes.NewMessageTokenID(1, 1)},
+ expectedMsgIDs: []reader.MessageTokenID{reader.NewMessageTokenID(1, 1)},
  },
  {
  name: "single token message but different chain",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{
- exectypes.NewMessageTokenID(1, 2): {
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{
+ reader.NewMessageTokenID(1, 2): {
  ExtraData: reader.NewSourceTokenDataPayload(31, ethereumDomainCCTP).ToBytes(),
  },
  },
  sourceChain: ethereumChain,
  destChain: polygonChain,
- expectedMsgIDs: []exectypes.MessageTokenID{exectypes.NewMessageTokenID(1, 2)},
+ expectedMsgIDs: []reader.MessageTokenID{reader.NewMessageTokenID(1, 2)},
  },
  {
  name: "message without matching nonce",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{
- exectypes.NewMessageTokenID(1, 1): {
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{
+ reader.NewMessageTokenID(1, 1): {
  ExtraData: reader.NewSourceTokenDataPayload(1234, ethereumDomainCCTP).ToBytes(),
  },
  },
  sourceChain: ethereumChain,
  destChain: avalancheChain,
- expectedMsgIDs: []exectypes.MessageTokenID{},
+ expectedMsgIDs: []reader.MessageTokenID{},
  },
  {
  name: "message without matching source domain",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{
- exectypes.NewMessageTokenID(1, 1): {
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{
+ reader.NewMessageTokenID(1, 1): {
  ExtraData: reader.NewSourceTokenDataPayload(11, avalancheDomainCCTP).ToBytes(),
  },
  },
  sourceChain: ethereumChain,
  destChain: avalancheChain,
- expectedMsgIDs: []exectypes.MessageTokenID{},
+ expectedMsgIDs: []reader.MessageTokenID{},
  },
  {
  name: "message with multiple tokens",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{
- exectypes.NewMessageTokenID(1, 1): {
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{
+ reader.NewMessageTokenID(1, 1): {
  ExtraData: reader.NewSourceTokenDataPayload(11, ethereumDomainCCTP).ToBytes(),
  },
- exectypes.NewMessageTokenID(1, 2): {
+ reader.NewMessageTokenID(1, 2): {
  ExtraData: reader.NewSourceTokenDataPayload(21, ethereumDomainCCTP).ToBytes(),
  },
  },
  sourceChain: ethereumChain,
  destChain: avalancheChain,
- expectedMsgIDs: []exectypes.MessageTokenID{
- exectypes.NewMessageTokenID(1, 1),
- exectypes.NewMessageTokenID(1, 2),
+ expectedMsgIDs: []reader.MessageTokenID{
+ reader.NewMessageTokenID(1, 1),
+ reader.NewMessageTokenID(1, 2),
  },
  },
  {
  name: "message with multiple tokens, one without matching nonce",
- tokens: map[exectypes.MessageTokenID]cciptypes.RampTokenAmount{
- exectypes.NewMessageTokenID(1, 1): {
+ tokens: map[reader.MessageTokenID]cciptypes.RampTokenAmount{
+ reader.NewMessageTokenID(1, 1): {
  ExtraData: reader.NewSourceTokenDataPayload(11, ethereumDomainCCTP).ToBytes(),
  },
- exectypes.NewMessageTokenID(1, 2): {
+ reader.NewMessageTokenID(1, 2): {
  ExtraData: reader.NewSourceTokenDataPayload(12, ethereumDomainCCTP).ToBytes(),
  },
- exectypes.NewMessageTokenID(1, 3): {
+ reader.NewMessageTokenID(1, 3): {
  ExtraData: reader.NewSourceTokenDataPayload(31, ethereumDomainCCTP).ToBytes(),
  },
  },
  sourceChain: ethereumChain,
  destChain: avalancheChain,
- expectedMsgIDs: []exectypes.MessageTokenID{
- exectypes.NewMessageTokenID(1, 1),
- exectypes.NewMessageTokenID(1, 3),
+ expectedMsgIDs: []reader.MessageTokenID{
+ reader.NewMessageTokenID(1, 1),
+ reader.NewMessageTokenID(1, 3),
  },
  },
  }

core/capabilities/ccip/configs/evm/contract_reader.go

@@ -162,6 +162,11 @@ var DestReaderConfig = evmrelaytypes.ChainReaderConfig{
  ChainSpecificName: mustGetMethodName("getVersionedConfig", rmnRemoteABI),
  ReadType: evmrelaytypes.Method,
  },
+ // TODO: to uncomment when the latest version of the contract will be merged.
+ // consts.MethodNameGetReportDigestHeader: {
+ // ChainSpecificName: mustGetMethodName("getReportDigestHeader", rmnRemoteABI),
+ // ReadType: evmrelaytypes.Method,
+ // },
  },
  },
  },

core/capabilities/ccip/delegate.go

@@ -21,12 +21,13 @@ import (
 
  ragep2ptypes "github.com/smartcontractkit/libocr/ragep2p/types"
 
- "github.com/smartcontractkit/chainlink-ccip/pkg/consts"
- ccipreaderpkg "github.com/smartcontractkit/chainlink-ccip/pkg/reader"
  "github.com/smartcontractkit/chainlink-common/pkg/sqlutil"
  "github.com/smartcontractkit/chainlink-common/pkg/types"
  "github.com/smartcontractkit/chainlink-common/pkg/types/query/primitives"
 
+ "github.com/smartcontractkit/chainlink-ccip/pkg/consts"
+ ccipreaderpkg "github.com/smartcontractkit/chainlink-ccip/pkg/reader"
+
  chainsel "github.com/smartcontractkit/chain-selectors"
 
  cciptypes "github.com/smartcontractkit/chainlink-common/pkg/types/ccipocr3"

core/capabilities/ccip/oraclecreator/plugin.go

@@ -4,13 +4,15 @@ import (
  "context"
  "encoding/json"
  "fmt"
+ "io"
  "math/big"
  "time"
 
  "github.com/ethereum/go-ethereum/common"
  "github.com/ethereum/go-ethereum/common/hexutil"
  "github.com/google/uuid"
  "github.com/prometheus/client_golang/prometheus"
+ chainsel "github.com/smartcontractkit/chain-selectors"
  "github.com/smartcontractkit/libocr/offchainreporting2plus/ocr3confighelper"
 
  "github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/ccipevm"
@@ -20,8 +22,6 @@ import (
  "github.com/smartcontractkit/chainlink/v2/core/chains/evm/assets"
  "github.com/smartcontractkit/chainlink/v2/core/chains/evm/config/toml"
 
- chainsel "github.com/smartcontractkit/chain-selectors"
-
  "github.com/smartcontractkit/libocr/commontypes"
  libocr3 "github.com/smartcontractkit/libocr/offchainreporting2plus"
  "github.com/smartcontractkit/libocr/offchainreporting2plus/ocr3types"
@@ -203,7 +203,15 @@ func (i *pluginOracleCreator) Create(donID uint32, config cctypes.OCR3ConfigWith
  if err != nil {
  return nil, err
  }
- return oracle, nil
+
+ closers := make([]io.Closer, 0, len(contractReaders)+len(chainWriters))
+ for _, cr := range contractReaders {
+ closers = append(closers, cr)
+ }
+ for _, cw := range chainWriters {
+ closers = append(closers, cw)
+ }
+ return newWrappedOracle(oracle, closers), nil
 }
 
 func (i *pluginOracleCreator) createFactoryAndTransmitter(
@@ -372,7 +380,7 @@ func decodeAndValidateOffchainConfig(
  if err1 != nil {
  return offChainConfig{}, fmt.Errorf("failed to decode commit offchain config: %w, raw: %s", err1, string(publicConfig.ReportingPluginConfig))
  }
- if err2 := commitOffchainCfg.Validate(); err2 != nil {
+ if err2 := commitOffchainCfg.ApplyDefaultsAndValidate(); err2 != nil {
  return offChainConfig{}, fmt.Errorf("failed to validate commit offchain config: %w", err2)
  }
  ofc.commitOffchainConfig = &commitOffchainCfg

core/capabilities/ccip/oraclecreator/wrapped_oracle.go

@@ -0,0 +1,42 @@
+package oraclecreator
+
+import (
+ "errors"
+ "fmt"
+ "io"
+
+ "github.com/smartcontractkit/chainlink-common/pkg/services"
+
+ cctypes "github.com/smartcontractkit/chainlink/v2/core/capabilities/ccip/types"
+)
+
+// wrappedOracle is a wrapper for cctypes.CCIPOracle that allows custom actions on Oracle shutdown.
+type wrappedOracle struct {
+ baseOracle cctypes.CCIPOracle
+
+ // closableResources will be closed after calling baseOracle.Close()
+ closableResources []io.Closer
+}
+
+func newWrappedOracle(baseOracle cctypes.CCIPOracle, closableResources []io.Closer) cctypes.CCIPOracle {
+ return &wrappedOracle{
+ baseOracle: baseOracle,
+ closableResources: closableResources,
+ }
+}
+
+func (o *wrappedOracle) Start() error {
+ return o.baseOracle.Start()
+}
+
+func (o *wrappedOracle) Close() error {
+ errs := make([]error, 0)
+
+ if err := o.baseOracle.Close(); err != nil {
+ errs = append(errs, fmt.Errorf("close base oracle: %w", err))
+ }
+
+ errs = append(errs, services.CloseAll(o.closableResources...))
+
+ return errors.Join(errs...)
+}