Remove custom ed25519 private to public key conversion. (#15416)

* Minor. * Minor
smartcontractkit · Dec 2, 2024 · dcc6a36 · dcc6a36
1 parent 04fb045
commit dcc6a36
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 11 deletions.
diff --git a/.changeset/cool-penguins-raise.md b/.changeset/cool-penguins-raise.md
@@ -0,0 +1,5 @@
+---
+"chainlink": minor
+---
+
+#updated Remove custom ed25519 private to public key conversion.
diff --git a/core/services/keystore/keys/csakey/key_v2.go b/core/services/keystore/keys/csakey/key_v2.go
@@ -16,7 +16,7 @@ func (raw Raw) Key() KeyV2 {
 	privKey := ed25519.PrivateKey(raw)
 	return KeyV2{
 		privateKey: &privKey,
-		PublicKey:  ed25519PubKeyFromPrivKey(privKey),
+		PublicKey:  privKey.Public().(ed25519.PublicKey),
 	}
 }
 
@@ -66,7 +66,7 @@ func MustNewV2XXXTestingOnly(k *big.Int) KeyV2 {
 	privKey := ed25519.NewKeyFromSeed(seed)
 	return KeyV2{
 		privateKey: &privKey,
-		PublicKey:  ed25519PubKeyFromPrivKey(privKey),
+		PublicKey:  privKey.Public().(ed25519.PublicKey),
 		Version:    2,
 	}
 }
@@ -90,9 +90,3 @@ func (k KeyV2) String() string {
 func (k KeyV2) GoString() string {
 	return k.String()
 }
-
-func ed25519PubKeyFromPrivKey(privKey ed25519.PrivateKey) ed25519.PublicKey {
-	publicKey := make([]byte, ed25519.PublicKeySize)
-	copy(publicKey, privKey[32:])
-	return publicKey
-}
diff --git a/core/services/keystore/keys/solkey/key.go b/core/services/keystore/keys/solkey/key.go
@@ -17,11 +17,9 @@ type Raw []byte
 // Key gets the Key
 func (raw Raw) Key() Key {
 	privKey := ed25519.NewKeyFromSeed(raw)
-	pubKey := make([]byte, ed25519.PublicKeySize)
-	copy(pubKey, privKey[ed25519.PublicKeySize:])
 	return Key{
 		privkey: privKey,
-		pubKey:  pubKey,
+		pubKey:  privKey.Public().(ed25519.PublicKey),
 	}
 }