Skip to content

Commit

Permalink
logging, edge case fixes (#15696)
Browse files Browse the repository at this point in the history
  • Loading branch information
krehermann authored Dec 16, 2024
1 parent 329e8f0 commit b76f9b3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 3 additions & 1 deletion deployment/common/proposalutils/mcms_helpers.go
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,9 @@ func RunTimelockExecutor(env deployment.Environment, cfg RunTimelockExecutorConf
Value: it.Event.Value,
})
}

if len(calls) == 0 {
return fmt.Errorf("no calls found for chain %d in blocks [%d, %d]", cfg.ChainSelector, *start, *end)
}
timelockExecutorProxy, err := owner_helpers.NewRBACTimelock(cfg.TimelockContracts.CallProxy.Address(), env.Chains[cfg.ChainSelector].Client)
if err != nil {
return fmt.Errorf("error creating timelock executor proxy: %w", err)
Expand Down
4 changes: 4 additions & 0 deletions deployment/keystone/deploy.go
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,10 @@ func RegisterCapabilities(lggr logger.Logger, req RegisterCapabilitiesRequest) (
for cap := range uniqueCaps {
capabilities = append(capabilities, cap)
}
if len(capabilities) == 0 {
lggr.Warn("no new capabilities to register")
return &RegisterCapabilitiesResponse{}, nil
}
// not using mcms; ignore proposals
_, err = AddCapabilities(lggr, &contracts, registryChain, capabilities, false)
if err != nil {
Expand Down

0 comments on commit b76f9b3

Please sign in to comment.