Skip to content

Commit

Permalink
Revert "Read config from env var first then override with TOML"
Browse files Browse the repository at this point in the history
This reverts commit 2b2fb18.
  • Loading branch information
lukaszcl committed Sep 18, 2024
1 parent f3b60d5 commit 9a5d891
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions integration-tests/testconfig/testconfig.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,18 +312,6 @@ func GetConfig(configurationNames []string, product Product) (TestConfig, error)
testConfig := TestConfig{}
testConfig.ConfigurationNames = configurationNames

logger.Info().Msg("Setting env vars from testsecrets dot-env files")
err := ctf_config.LoadSecretEnvsFromFiles()
if err != nil {
return TestConfig{}, errors.Wrapf(err, "error reading test config values from ~/.testsecrets file")
}

logger.Info().Msg("Reading config values from existing env vars")
err = testConfig.ReadFromEnvVar()
if err != nil {
return TestConfig{}, errors.Wrapf(err, "error reading test config values from env vars")
}

logger.Debug().Msgf("Will apply configurations named '%s' if they are found in any of the configs", strings.Join(configurationNames, ","))

// read embedded configs is build tag "embed" is set
Expand Down Expand Up @@ -377,6 +365,18 @@ func GetConfig(configurationNames []string, product Product) (TestConfig, error)
}
}

logger.Info().Msg("Setting env vars from testsecrets dot-env files")
err := ctf_config.LoadSecretEnvsFromFiles()
if err != nil {
return TestConfig{}, errors.Wrapf(err, "error reading test config values from ~/.testsecrets file")
}

logger.Info().Msg("Reading config values from existing env vars")
err = testConfig.ReadFromEnvVar()
if err != nil {
return TestConfig{}, errors.Wrapf(err, "error reading test config values from env vars")
}

logger.Info().Msgf("Overriding config from %s env var", Base64OverrideEnvVarName)
configEncoded, isSet := os.LookupEnv(Base64OverrideEnvVarName)
if isSet && configEncoded != "" {
Expand Down

0 comments on commit 9a5d891

Please sign in to comment.