fixing health tests

smartcontractkit · Jan 10, 2025 · 8b02f20 · 8b02f20
1 parent 0e5c40d
commit 8b02f20
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 2 deletions.
diff --git a/core/services/chainlink/application.go b/core/services/chainlink/application.go
@@ -232,7 +232,7 @@ func (h *ApplicationHeartbeat) start(_ context.Context) error {
 	cme := custmsg.NewLabeler()
 
 	// Define tick functions
-	tickFn := func(engCtx context.Context) {
+	beatFn := func(engCtx context.Context) {
 		// TODO allow override of tracer provider into engine for beholder
 		_, innerSpan := beholder.GetTracer().Start(engCtx, "heartbeat.beat")
 		defer innerSpan.End()
@@ -251,7 +251,7 @@ func (h *ApplicationHeartbeat) start(_ context.Context) error {
 		return h.beat
 	}
 
-	h.eng.GoTick(timeutil.NewTicker(constantTickFn), tickFn)
+	h.eng.GoTick(timeutil.NewTicker(constantTickFn), beatFn)
 	return nil
 }
 

diff --git a/core/web/testdata/body/health.html b/core/web/testdata/body/health.html
@@ -111,6 +111,9 @@
         </details>
     </details>
 </details>
+<details open>
+    <summary title="NodeHeartbeat" class="noexpand"><span class="passing">NodeHeartbeat</span></summary>
+</details>
 <details open>
     <summary title="PipelineORM" class="noexpand"><span class="passing">PipelineORM</span></summary>
 </details>

diff --git a/core/web/testdata/body/health.json b/core/web/testdata/body/health.json
@@ -189,6 +189,15 @@
         "output": ""
       }
     },
+    {
+      "type": "checks",
+      "id": "NodeHeartbeat",
+      "attributes": {
+        "name": "NodeHeartbeat",
+        "status": "passing",
+        "output": ""
+      }
+    },
     {
       "type": "checks",
       "id": "PipelineORM",

diff --git a/core/web/testdata/body/health.txt b/core/web/testdata/body/health.txt
@@ -20,6 +20,7 @@ ok JobSpawner
 ok Mailbox.Monitor
 ok Mercury.WSRPCPool
 ok Mercury.WSRPCPool.CacheSet
+ok NodeHeartbeat
 ok PipelineORM
 ok PipelineRunner
 ok PipelineRunner.BridgeCache