Skip to content

Commit

Permalink
cleaning up
Browse files Browse the repository at this point in the history
  • Loading branch information
yashnevatia committed Dec 4, 2024
1 parent dce6eac commit 5359428
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 14 deletions.
10 changes: 1 addition & 9 deletions .github/workflows/solidity-wrappers.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,19 +52,11 @@ jobs:
uses: ./.github/actions/setup-nodejs
with:
prod: "true"

# - name: Run native compile and generate wrappers
# run: make wrappers
# working-directory: ./contracts
# env:
# FOUNDRY_PROFILE: ccip

- name: Run native compile and generate wrappers
run: make wrappers-all
working-directory: ./contracts
# env:
# FOUNDRY_PROFILE: ccip


- name: Assume role capable of dispatching action
uses: smartcontractkit/.github/actions/setup-github-token@ef78fa97bf3c77de6563db1175422703e9e6674f # [email protected]
id: get-gh-token
Expand Down
3 changes: 0 additions & 3 deletions contracts/scripts/native_solc_compile_all_ccip
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@ ROOT="$( cd "$(dirname "$0")" >/dev/null 2>&1 ; cd ../../ && pwd -P )"
compileContract () {
local contract
contract=$(basename "$1" ".sol")
echo "compiling $contract"

local optimize_runs=$OPTIMIZE_RUNS

Expand All @@ -41,8 +40,6 @@ compileContract () {
--evm-version paris \
"$ROOT"/contracts/src/v0.8/"$1"

echo "compiling $contract zksolc"
zksolc --version
zksolc --overwrite -O3 --metadata-hash none \
-o "$ROOT"/contracts/zksolc/v$ZKSOLC_VERSION/"$contract" \
--bin --allow-paths "$ROOT"/contracts/src/v0.8 \
Expand Down
4 changes: 2 additions & 2 deletions core/gethwrappers/abigen.go
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ func Abigen(a AbigenArgs) {

ImproveAbigenOutput(a.Out, a.ABI)
if a.ZkBinPath != "" {
ImproveAbigenOutput_zks(a.Out, a.ZkBinPath)
ImproveAbigenOutputZks(a.Out, a.ZkBinPath)
}
}

Expand Down Expand Up @@ -471,7 +471,7 @@ func addHeader(code []byte) []byte {
}

// ZK stack logic
func ImproveAbigenOutput_zks(path string, zkBinPath string) {
func ImproveAbigenOutputZks(path string, zkBinPath string) {

Check failure on line 474 in core/gethwrappers/abigen.go

View workflow job for this annotation

GitHub Actions / lint

unnecessary leading newline (whitespace)

bs, err := os.ReadFile(path)
if err != nil {
Expand Down

0 comments on commit 5359428

Please sign in to comment.