Skip to content

Commit

Permalink
address more comments
Browse files Browse the repository at this point in the history
  • Loading branch information
EasterTheBunny committed Sep 9, 2024
1 parent e074d68 commit 4c5981d
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion core/services/relay/evm/chain_reader.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,6 +309,7 @@ func (cr *chainReader) getEventInput(def types.ChainReaderDefinition, contractNa
types.CodecEntry, commoncodec.Modifier, error) {
inputInfo := cr.parsed.EncoderDefs[WrapItemType(contractName, eventName, true)]

// TODO can this be simplified? Isn't this same as inputInfo.Modifier()? BCI-3909
inMod, err := def.InputModifications.ToModifier(codec.DecoderHooks...)
if err != nil {
return nil, nil, err
Expand All @@ -324,7 +325,6 @@ func (cr *chainReader) getEventInput(def types.ChainReaderDefinition, contractNa

func (cr *chainReader) addEncoderDef(contractName, itemType string, args abi.Arguments, prefix []byte, inputModifications commoncodec.ModifiersConfig) error {
// ABI.Pack prepends the method.ID to the encodings, we'll need the encoder to do the same.
// TODO can this be simplified? Isn't this same as inputInfo.Modifier()? BCI-3909
inputMod, err := inputModifications.ToModifier(codec.DecoderHooks...)
if err != nil {
return err
Expand Down
2 changes: 0 additions & 2 deletions core/services/relay/evm/evmtesting/run_tests.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
package evmtesting

import (
"log"
"math/big"
"reflect"
"time"
Expand Down Expand Up @@ -42,7 +41,6 @@ func RunContractReaderEvmTests[T TestingT[T]](t T, it *EVMChainComponentsInterfa
}
SubmitTransactionToCW(t, it, "triggerEventWithDynamicTopic", DynamicEvent{Field: anyString}, bindings[0], types.Unconfirmed)

log.Println("TRACE: setup complete")
input := struct{ Field string }{Field: anyString}
tp := cr.(clcommontypes.ContractTypeProvider)

Expand Down

0 comments on commit 4c5981d

Please sign in to comment.