Skip to content

Commit

Permalink
apply CR changes
Browse files Browse the repository at this point in the history
  • Loading branch information
Tofel committed Aug 7, 2024
1 parent 26a5cf3 commit 024e9e3
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 11 deletions.
4 changes: 2 additions & 2 deletions .github/actions/setup-slither/action.yaml
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
name: Setup Slither
description: Installs Slither for contract analysis. Requires Python 3.6 or higher.
description: Installs Slither 0.10.3 for contract analysis. Requires Python 3.6 or higher.
runs:
using: composite
steps:
- name: Install Slither
shell: bash
run: |
python -m pip install --upgrade pip
pip install slither-analyzer
pip install slither-analyzer==0.10.3
1 change: 0 additions & 1 deletion .github/actions/setup-solc-select/action.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ runs:
shell: bash
run: |
sudo apt-get update
sudo apt-get install -y python3-pip
pip3 install solc-select
sudo ln -s /usr/local/bin/solc-select /usr/bin/solc-select
Expand Down
5 changes: 0 additions & 5 deletions .github/workflows/solidity-foundry.yml
Original file line number Diff line number Diff line change
Expand Up @@ -235,11 +235,6 @@ jobs:
- name: Setup NodeJS
uses: ./.github/actions/setup-nodejs

- name: Install semver
shell: bash
run: |
npm install -g semver
- name: Install Foundry
uses: foundry-rs/foundry-toolchain@8f1998e9878d786675189ef566a2e4bf24869773 # v1.2.0
with:
Expand Down
2 changes: 1 addition & 1 deletion contracts/scripts/ci/generate_slither_report.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

function check_chainlink_dir() {
local param_dir="chainlink"
Expand Down
4 changes: 3 additions & 1 deletion contracts/scripts/ci/modify_remappings.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/bin/bash
#!/usr/bin/env bash

set -euo pipefail

if [ "$#" -ne 2 ]; then
>&2 echo "Usage: $0 <directory_prefix> <remappings_file>"
Expand Down
2 changes: 1 addition & 1 deletion contracts/scripts/ci/select_solc_version.sh
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/bash
#!/usr/bin/env bash

function check_chainlink_dir() {
local param_dir="chainlink"
Expand Down

0 comments on commit 024e9e3

Please sign in to comment.