Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Solana Client for LogPoller #933

Merged
merged 10 commits into from
Dec 5, 2024
Merged

Update Solana Client for LogPoller #933

merged 10 commits into from
Dec 5, 2024

Conversation

DylanTinianov
Copy link
Contributor

@DylanTinianov DylanTinianov commented Nov 19, 2024 •
edited
Loading

Description

Added the following methods required for LogPoller

GetSignaturesForAddressWithOpts(ctx context.Context, address solana.Publickey, opts *GetSignaturesForAddressOpts) ([]*solana.TransactionSignature, error)
GetTransaction(ctx context.Context, txHash solana.Signature, opts *solana.GetTransactionOpts) (*GetTransactionResult, err error)
GetBlocks(ctx context.Context, startSlot uint64, endSlot *uint64) (out rpc.BlocksResult, err error)

Ticket: https://smartcontract-it.atlassian.net/browse/NONEVM-743

@DylanTinianov DylanTinianov self-assigned this Nov 19, 2024
@DylanTinianov DylanTinianov requested a review from a team as a code owner November 19, 2024 17:47
@reductionista
Copy link
Contributor

I notice there is a GetBlocksWithLimit() method here, but we don't have GetBlocks(). @EasterTheBunny 's PR uses the latter: #911 (files)

This makes me realize though, maybe we should be using GetBlocksWithLimit? At least one of these PR's needs to be updated, I'm not sure off the top of my head which one but I'll leave an update when we get it figured out.

Ok yeah, actually we do need GetBlocks(). GetBlocksWithLimit doesn't allow you to specify an upper slot limit only lower. @DylanTinianov can you add that one to this PR?

@DylanTinianov DylanTinianov marked this pull request as draft November 19, 2024 19:06
@aalu1418 aalu1418 enabled auto-merge (squash) December 5, 2024 17:52
@cl-sonarqube-production
Copy link

Quality Gate failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 75%)

See analysis details on SonarQube

@aalu1418 aalu1418 merged commit f7ecca8 into develop Dec 5, 2024
34 of 35 checks passed
@aalu1418 aalu1418 deleted the NONEVM-743-logpoller-rpcclient branch December 5, 2024 18:11
Tofel pushed a commit that referenced this pull request Dec 6, 2024
@DylanTinianov @Tofel
Update Solana Client for LogPoller (#933)
7d3d88c 
* Add required methods

* Add GetBlocks

* Add GetBlocks method
aalu1418 added a commit that referenced this pull request Dec 6, 2024
@Tofel @aalu1418 @DylanTinianov
[TT-1806] add required chain.link labels to k8s soak test (#944)
77c4275 
* add required chain.link labels to k8s soak test

* tagged CTF + team input in the soak workflow

* add missing import

* fix compilation

* fix CL version in go.mod

* add missing var to e2e tests

* use chainlink & integration-tests commit from develop branch

* fix: add chainlink/deployment bump to updater workflow (#961)

* Update Solana Client for LogPoller (#933)

* Add required methods

* Add GetBlocks

* Add GetBlocks method

---------

Co-authored-by: Aaron Lu <[email protected]>
Co-authored-by: Dylan Tinianov <[email protected]>
dhaidashenko pushed a commit that referenced this pull request Dec 20, 2024
@DylanTinianov @dhaidashenko
Update Solana Client for LogPoller (#933)
cab2ad9 
* Add required methods

* Add GetBlocks

* Add GetBlocks method
dhaidashenko pushed a commit that referenced this pull request Dec 20, 2024
@Tofel @aalu1418
@DylanTinianov @dhaidashenko
[TT-1806] add required chain.link labels to k8s soak test (#944)
c681921 
* add required chain.link labels to k8s soak test

* tagged CTF + team input in the soak workflow

* add missing import

* fix compilation

* fix CL version in go.mod

* add missing var to e2e tests

* use chainlink & integration-tests commit from develop branch

* fix: add chainlink/deployment bump to updater workflow (#961)

* Update Solana Client for LogPoller (#933)

* Add required methods

* Add GetBlocks

* Add GetBlocks method

---------

Co-authored-by: Aaron Lu <[email protected]>
Co-authored-by: Dylan Tinianov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aalu1418 aalu1418 aalu1418 approved these changes

@reductionista reductionista reductionista approved these changes

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

Assignees

@DylanTinianov DylanTinianov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DylanTinianov @reductionista @aalu1418