Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BCFR-966 - Update Solana to support disable chain component tests #878

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

BCFR-966 - Update Solana to support disable chain component tests #878

wants to merge 1 commit into from

Conversation

pablolagreca
Copy link

Description

Add missing methods to support disabling chain component tests

@pablolagreca pablolagreca requested review from a team as code owners October 3, 2024 14:47
@cl-sonarqube-production
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube

Farber98
Farber98 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Contributor

@Farber98 Farber98 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should make a follow up PR to use this logic for skipping tests instead of doing it manually through Skip()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Farber98 Farber98 Farber98 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pablolagreca @Farber98