Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOM: network fees #728

Merged
merged 1 commit into from
Jun 5, 2024
Merged

SOM: network fees #728

merged 1 commit into from
Jun 5, 2024

Conversation

aalu1418
Copy link
Collaborator

@aalu1418 aalu1418 marked this pull request as ready for review May 30, 2024 20:40
@aalu1418 aalu1418 requested review from a team as code owners May 30, 2024 20:40
@aalu1418 aalu1418 force-pushed the som/network-fees branch from 4540f99 to 532d2b6 Compare May 30, 2024 20:52
p.metrics.Cleanup()
}

func aggregateFees[V constraints.Integer](input metrics.NetworkFeesInput, name string, data []V) error {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice use of the generic

augustbleeds
augustbleeds previously approved these changes Jun 5, 2024
Base automatically changed from feat/block-history-est to develop June 5, 2024 17:02
@aalu1418 aalu1418 dismissed augustbleeds’s stale review June 5, 2024 17:02

The base branch was changed.

@augustbleeds augustbleeds requested review from a team as code owners June 5, 2024 17:02
@aalu1418 aalu1418 merged commit b4a91ae into develop Jun 5, 2024
25 checks passed
@aalu1418 aalu1418 deleted the som/network-fees branch June 5, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants