[CAPPL-320] implement HexDecodeWorkflowName #983
Merged
+233
−202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmank88
requested changes
Jan 7, 2025
pkg/workflows/utils.go
Outdated
Comment on lines
90
to
96
| // HexDecodeWorkflowName makes the best effort to decode the hex workflow name. | ||
| // In case of failure it will log the error and return the input name. | ||
| func HexDecodeWorkflowName(encoded string, logger logger.Logger) string { | ||
| decoded, err := hex.DecodeString(encoded) | ||
| if err != nil { | ||
| logger.Errorf("failed to decode WorkflowName %q: %v", encoded, err) | ||
| return encoded |
There was a problem hiding this comment.
Passing a logger as a function argument is usually a code smell. Where is this used?
There was a problem hiding this comment.
I've removed this, we are going to expose a new decodedWorkflowName as part of the metadata. The decoding will happen in chainlink instead. Will change the implementation there to not pass the logger 🙇🏼
MStreet3
previously approved these changes
Jan 8, 2025
cedric-cordenier
previously approved these changes
Jan 8, 2025
agparadiso
dismissed stale reviews from cedric-cordenier and MStreet3
via
40f0d97
MStreet3
approved these changes
Jan 8, 2025
cedric-cordenier
approved these changes
Jan 8, 2025
jmank88
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr adds the
DecodedWorkflowNamefield that will be used here in order to log the workflowname correctly to beholderCAPPL-320
Requires
Supports