-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed flakey testcases and optimized for parallel test runs #965
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silaslenihan
changed the title
Removed Finality Checks that expect errors in ChainComponents tests"
Removed Finality Checks that expect errors in ChainComponents tests
Dec 6, 2024
silaslenihan
temporarily deployed
to
integration
December 6, 2024 00:12 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 6, 2024 00:12 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 6, 2024 00:12 — with
GitHub Actions
Inactive
george-dorin
previously approved these changes
Dec 6, 2024
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 6, 2024 16:23
bb7a47a
to
10f03fd
Compare
silaslenihan
temporarily deployed
to
integration
December 6, 2024 16:24 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 6, 2024 16:24 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 6, 2024 16:24 — with
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
December 17, 2024 14:25 — with
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
December 17, 2024 14:25 — with
GitHub Actions
Error
silaslenihan
had a problem deploying
to
integration
December 17, 2024 14:25 — with
GitHub Actions
Error
silaslenihan
changed the title
Removed Finality Checks that expect errors in ChainComponents tests
Removed flakey testcases and optimized for parallel test runs
Dec 17, 2024
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 17, 2024 14:27
0384b94
to
17370c5
Compare
silaslenihan
temporarily deployed
to
integration
December 17, 2024 14:28 — with
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
December 17, 2024 14:28 — with
GitHub Actions
Failure
silaslenihan
had a problem deploying
to
integration
December 17, 2024 14:28 — with
GitHub Actions
Error
silaslenihan
had a problem deploying
to
integration
December 17, 2024 14:33 — with
GitHub Actions
Failure
silaslenihan
temporarily deployed
to
integration
December 17, 2024 14:33 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 17, 2024 14:33 — with
GitHub Actions
Inactive
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 17, 2024 15:27
5bd6eb4
to
c54b7c7
Compare
silaslenihan
temporarily deployed
to
integration
December 17, 2024 15:27 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 17, 2024 15:27 — with
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
December 17, 2024 15:27 — with
GitHub Actions
Failure
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 17, 2024 17:09
c54b7c7
to
37a466b
Compare
silaslenihan
had a problem deploying
to
integration
December 17, 2024 17:09 — with
GitHub Actions
Error
silaslenihan
temporarily deployed
to
integration
December 17, 2024 17:10 — with
GitHub Actions
Inactive
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 17, 2024 17:24
34e00cf
to
646628c
Compare
silaslenihan
temporarily deployed
to
integration
December 17, 2024 17:24 — with
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
December 17, 2024 17:25 — with
GitHub Actions
Failure
silaslenihan
temporarily deployed
to
integration
December 17, 2024 17:25 — with
GitHub Actions
Inactive
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 17, 2024 20:06
646628c
to
e0cabf5
Compare
silaslenihan
temporarily deployed
to
integration
December 17, 2024 20:06 — with
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
December 17, 2024 20:06 — with
GitHub Actions
Failure
silaslenihan
temporarily deployed
to
integration
December 17, 2024 20:06 — with
GitHub Actions
Inactive
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 18, 2024 15:56
e0cabf5
to
e23c08f
Compare
silaslenihan
temporarily deployed
to
integration
December 18, 2024 15:57 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 18, 2024 15:57 — with
GitHub Actions
Inactive
silaslenihan
had a problem deploying
to
integration
December 18, 2024 15:57 — with
GitHub Actions
Failure
jmank88
reviewed
Dec 18, 2024
pkg/loop/internal/relayer/pluginprovider/contractreader/__debug_bin3704910103
Outdated
Show resolved
Hide resolved
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 18, 2024 21:33
e23c08f
to
c964905
Compare
silaslenihan
had a problem deploying
to
integration
December 18, 2024 21:33 — with
GitHub Actions
Failure
silaslenihan
temporarily deployed
to
integration
December 18, 2024 21:33 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 18, 2024 21:33 — with
GitHub Actions
Inactive
ilija42
approved these changes
Dec 18, 2024
silaslenihan
force-pushed
the
remove-finality-expected-errors
branch
from
December 20, 2024 19:06
c964905
to
91ac800
Compare
silaslenihan
had a problem deploying
to
integration
December 20, 2024 19:06 — with
GitHub Actions
Failure
silaslenihan
temporarily deployed
to
integration
December 20, 2024 19:06 — with
GitHub Actions
Inactive
silaslenihan
temporarily deployed
to
integration
December 20, 2024 19:06 — with
GitHub Actions
Inactive
jmank88
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes some problematic checks from the ChainComponents interface tests. We test the ChainReader's ability to read a value at a specific confidence level. The tests work by submitting a transaction to the unconfirmed state, then trying to read the value at the Finalized level expecting an error. The issue here is that on certain chains, finality is instantaneous, and even when running on the Simulated Backend, sometimes there is a race condition where finality is achieved before those checks can go through. Since these tests are supposed to be chain agnostic (including for instant finality chains) we should remove these two checks to avoid unwanted behavior on instant finality chains and race conditions on EVM.
Additionally, this PR enables parallel running of ChainComponents Tests in order to drastically reduce runtime.
Requires
Supports