Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed flakey testcases and optimized for parallel test runs #965

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

silaslenihan
Copy link
Contributor

@silaslenihan silaslenihan commented Dec 6, 2024

This PR removes some problematic checks from the ChainComponents interface tests. We test the ChainReader's ability to read a value at a specific confidence level. The tests work by submitting a transaction to the unconfirmed state, then trying to read the value at the Finalized level expecting an error. The issue here is that on certain chains, finality is instantaneous, and even when running on the Simulated Backend, sometimes there is a race condition where finality is achieved before those checks can go through. Since these tests are supposed to be chain agnostic (including for instant finality chains) we should remove these two checks to avoid unwanted behavior on instant finality chains and race conditions on EVM.

Additionally, this PR enables parallel running of ChainComponents Tests in order to drastically reduce runtime.

Requires

Supports

@silaslenihan silaslenihan requested a review from a team as a code owner December 6, 2024 00:11
@silaslenihan silaslenihan changed the title Removed Finality Checks that expect errors in ChainComponents tests" Removed Finality Checks that expect errors in ChainComponents tests Dec 6, 2024
george-dorin
george-dorin previously approved these changes Dec 6, 2024
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from bb7a47a to 10f03fd Compare December 6, 2024 16:23
@silaslenihan silaslenihan changed the title Removed Finality Checks that expect errors in ChainComponents tests Removed flakey testcases and optimized for parallel test runs Dec 17, 2024
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from 0384b94 to 17370c5 Compare December 17, 2024 14:27
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from 5bd6eb4 to c54b7c7 Compare December 17, 2024 15:27
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from c54b7c7 to 37a466b Compare December 17, 2024 17:09
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from 34e00cf to 646628c Compare December 17, 2024 17:24
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from 646628c to e0cabf5 Compare December 17, 2024 20:06
@silaslenihan silaslenihan force-pushed the remove-finality-expected-errors branch from e0cabf5 to e23c08f Compare December 18, 2024 15:56
@silaslenihan silaslenihan merged commit db7919d into main Dec 23, 2024
8 of 11 checks passed
@silaslenihan silaslenihan deleted the remove-finality-expected-errors branch December 23, 2024 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants