[BCI-3862][chainlink-common] - Change DSL Block primitive to string instead of int

[Farber98]

Task Description:

Change ChainReader block DSL uint64 type to string and update EVM implementation to reflect changes

This PR:

Changed the block proto field and fixed all the reference failures within chainlink-common

Ticket:

• BCI-3862

Unblocks:

• [BCI-3862][chainlink] - Change DSL Block primitive to string instead of int chainlink#14033

[Farber98]

Should I instead deprecate the previous field and add a new one because of backward compatibility? Could try if something like this works:

message Block {
  uint64 block_number_deprecated = 1 [deprecated = true]; // rename prev field and mark as deprecated
  string block_number = 3; // new field with string type that has the old name
  ComparisonOperator operator = 2;
}

[ilija42]

Usually that is the best practice, but I don't see anyone using block querying so as long as you update tests in core evm it is fine to make a breaking change.

[ilija42]

You'll have to update the PGDSLParser here, and check if any of the LP tests need to be fixed after this change

[Farber98]

Fixed in this PR: smartcontractkit/chainlink#14033

[Farber98]

"update EVM implementation to reflect changes" means updating this file? I don't see we are directly referencing the changed field

[Farber98]

reopened here with signed commits #688