Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BCF-3247] - Remove pending from boundContract and use confidence instead for CR #573

Merged
merged 6 commits into from
Jul 10, 2024
Merged

[BCF-3247] - Remove pending from boundContract and use confidence instead for CR #573

merged 6 commits into from
Jul 10, 2024

Conversation

ilija42
Copy link
Contributor

@ilija42 ilija42 commented Jun 11, 2024 •
edited
Loading

core ref: df3b03391fed8594b9bb0a6d9d625cb45c8fbdaa
solana ref: 458292c84c696c341df0164a260e191b9e8dffcf

Description

  • Modified proto and Client Server defs to support confidence levels for GetLatestValue
  • Wrote tests, but geth SimulatedBackend doesn't seem to support reading anything but the latest block, which breaks the tests, so I commented them out. Still confirmed that everything works, but not sure what to do with this.

Related PRs

chainlink
chainlink-feeds
chainlink-solana

@ilija42 ilija42 changed the title Remove pending from boundContract and use confidence instead for CR BCF-3247 Remove pending from boundContract and use confidence instead for CR Jun 11, 2024
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 0034e09 to 870c047 Compare June 11, 2024 17:53
@ilija42 ilija42 mentioned this pull request Jun 11, 2024
Merged
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 870c047 to baa671f Compare June 13, 2024 13:51
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from baa671f to 53ee92e Compare July 1, 2024 13:51
@ilija42 ilija42 changed the title BCF-3247 Remove pending from boundContract and use confidence instead for CR [BCF-3247] - Remove pending from boundContract and use confidence instead for CR Jul 1, 2024
@ilija42 ilija42 mentioned this pull request Jul 1, 2024
Merged
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 53ee92e to 97b80f8 Compare July 1, 2024 14:50
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from e0e5bba to 49b4030 Compare July 1, 2024 15:24
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from 71c6edb to beb4cc9 Compare July 9, 2024 12:36
@ilija42 ilija42 force-pushed the BCF-3247-CR-contract-read-finality branch from beb4cc9 to 3df55c8 Compare July 10, 2024 11:40
@krehermann krehermann merged commit ade916a into main Jul 10, 2024
10 checks passed
@krehermann krehermann deleted the BCF-3247-CR-contract-read-finality branch July 10, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krehermann krehermann krehermann approved these changes

@jmank88 jmank88 jmank88 approved these changes

@reductionista reductionista Awaiting requested review from reductionista

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ilija42 @jmank88 @krehermann