Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/services: add Ticker #311

Merged
merged 3 commits into from
Jun 12, 2024
Merged

pkg/services: add Ticker #311

merged 3 commits into from
Jun 12, 2024

Conversation

jmank88
Copy link
Collaborator

@jmank88 jmank88 commented Jan 12, 2024 •
edited
Loading

This PR introduces a services.Ticker which is like a time.Ticker but for cases that want to include jitter and fire immediately on the first round.

Supports:

@jmank88 jmank88 requested a review from patrickhuie19 January 12, 2024 14:06
@jmank88 jmank88 mentioned this pull request Jan 12, 2024
Merged
patrickhuie19
patrickhuie19 previously approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@patrickhuie19 patrickhuie19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@jmank88 jmank88 requested a review from samsondav February 13, 2024 20:44
samsondav
samsondav previously approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@samsondav samsondav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very handy

@jmank88 jmank88 dismissed stale reviews from samsondav and patrickhuie19 via 80b46be February 27, 2024 23:17
@jmank88 jmank88 marked this pull request as ready for review June 11, 2024 14:30
@jmank88 jmank88 requested a review from krebernisak as a code owner June 11, 2024 14:30
@jmank88 jmank88 merged commit 52ca905 into main Jun 12, 2024
7 of 8 checks passed
@jmank88 jmank88 deleted the services-ticker branch June 12, 2024 17:02
patrickhuie19 pushed a commit that referenced this pull request Jun 13, 2024
@jmank88 @patrickhuie19
pkg/services: add Ticker (#311)
2828f0a
@samsondav samsondav mentioned this pull request Jun 24, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhuie19 patrickhuie19 patrickhuie19 approved these changes

@krehermann krehermann krehermann approved these changes

@krebernisak krebernisak Awaiting requested review from krebernisak

@samsondav samsondav Awaiting requested review from samsondav

@EasterTheBunny EasterTheBunny Awaiting requested review from EasterTheBunny

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jmank88 @samsondav @krehermann @patrickhuie19