[CAPPL-471] Add more tests to verify that panic is handled #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
temporarily deployed
to
integration
GitHub Actions
Inactive
cedric-cordenier
had a problem deploying
to
integration
GitHub Actions
Failure
agparadiso
approved these changes
Jan 17, 2025
krehermann
approved these changes
Jan 17, 2025
| EnvVarsAssignedToNodes: nil, | ||
| }, | ||
| } | ||
| _, err = DecryptSecretsForNode(results, k, "owner") |
There was a problem hiding this comment.
table driven test for multiple error paths? can't tell from the test which of the field is required to be non-nil.
|
|
||
| // Define test cases | ||
| tests := []struct { | ||
| name string | ||
| inputData []byte | ||
| encryptionPublicKeys map[string][32]byte | ||
| workflowOwner string | ||
| shouldError bool | ||
| errMsg string |
There was a problem hiding this comment.
nit/ rename to wantErrMsg or expectedErrMsg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires
Supports