Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

audit contexts #335

Merged
merged 3 commits into from
Oct 23, 2024
Merged

audit contexts #335

merged 3 commits into from
Oct 23, 2024

Conversation

jmank88
Copy link
Contributor

@jmank88 jmank88 commented Oct 13, 2024

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mock constructors automatically register the *testing.T and AssertExpectations on t.Cleanup.

@jmank88 jmank88 marked this pull request as ready for review October 22, 2024 05:32
@@ -1,4 +1,4 @@
// Code generated by mockery v2.28.1. DO NOT EDIT.
// Code generated by mockery v2.43.2. DO NOT EDIT.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't mean to use a different version here. Shouldn't CI be failing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.tool-versions was on 2.12.1 even though these files were on 2.28.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumped to 2.43.2

@jmank88 jmank88 force-pushed the BCF-3204-background-context branch from e5b8d37 to d6daff8 Compare October 22, 2024 12:55
Copy link
Collaborator

@infiloop2 infiloop2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, added a small comment

infiloop2
infiloop2 previously approved these changes Oct 23, 2024
@infiloop2 infiloop2 merged commit a11c140 into main Oct 23, 2024
8 checks passed
@infiloop2 infiloop2 deleted the BCF-3204-background-context branch October 23, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants