-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scale observation building with massive amount of results #317
Merged
amirylm
merged 9 commits into
main
from
AUTO-9416-scale-observation-building-with-massive-amount-of-results
Apr 8, 2024
Merged
Scale observation building with massive amount of results #317
amirylm
merged 9 commits into
main
from
AUTO-9416-scale-observation-building-with-massive-amount-of-results
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infiloop2
reviewed
Apr 5, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks great to me!
Could we add some unit test coverage for the updated logic
ferglor
reviewed
Apr 5, 2024
ferglor
previously approved these changes
Apr 5, 2024
ferglor
approved these changes
Apr 8, 2024
amirylm
deleted the
AUTO-9416-scale-observation-building-with-massive-amount-of-results
branch
April 8, 2024 12:33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-9416
Description
Currently we sort the entire set of staged upkeeps by random seed order based on the OCR round/seq number, then take a limit of items to be added to observation.
As part of the sorting we are doing string shuffling with the random seed, which is CPU+memory intensive work that makes the entire operation slow, and breaks when scaling as we repeat the same expensive operation to get random order in each round. Eventually resulting in multiple “Observation is taking too long” warnings or even crushes the nodes.
We will use a random number every x rounds (e.g. 10) and maintain a cache for the shuffled work ids.
A map will be used to store shuffled ids, it will get cleaned every time the random source changes (10 rounds).
Changes