Spike: Debug linter #306
Closed
Spike: Debug linter #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like when a PR bumps the go version to 1.21, the linter goes a little crazy (specifically, we get a bunch of errors on the mockery mocks)
At first I thought that maybe we needed to use a newer version of mockery to generate our mocks, but this was unsuccessful
Looking at the workflow, we seem to be using a forked/outdated version of
golangci-lint-actionTo remedy this, I copied some of the settings out of the integration tests workflow in core, to use the same linter with similar args as seen here
With the workflow updated, the CI steps now pass, though I'm not sure if there's any additional tweaking we need here