Avoid encoding of RetryInterval #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infiloop2
reviewed
Nov 27, 2023
infiloop2
reviewed
Nov 27, 2023
infiloop2
approved these changes
Nov 27, 2023
ferglor
approved these changes
Nov 27, 2023
- added struct for encoding: checkResultMsg - overriden Un/MarshalJSON funcs - aligned existing tests - added new tests
amirylm
force-pushed
the
AUTO-7516-fix-check-result-regression
branch
from
01a75f2 to
7fa51db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AUTO-7516
Motivation
Fixing a breaking change that was introduced when
RetryIntervalwas added toCheckResultstruct.Description
Avoid the encoding and decoding of this property, by overriding MarshalJSON and UnmarshalJSON functions.
Changes